-
-
Notifications
You must be signed in to change notification settings - Fork 353
/
prefer-string-replace-all.mjs
104 lines (100 loc) · 2.14 KB
/
prefer-string-replace-all.mjs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
import {getTester} from './utils/test.mjs';
const {test} = getTester(import.meta);
const error = {
message: 'Prefer `String#replaceAll()` over `String#replace()`.',
};
test({
valid: [
// No global flag
'foo.replace(/a/, bar)',
// Special characters
'foo.replace(/[a]/g, bar)',
'foo.replace(/a?/g, bar)',
'foo.replace(/.*/g, bar)',
'foo.replace(/a|b/g, bar)',
'foo.replace(/\\W/g, bar)',
'foo.replace(/\\u{61}/g, bar)',
'foo.replace(/\\u{61}/gu, bar)',
// Extra flag
'foo.replace(/a/gi, bar)',
'foo.replace(/a/gui, bar)',
'foo.replace(/a/uig, bar)',
// Not regex literal
'foo.replace(\'string\', bar)',
// Not 2 arguments
'foo.replace(/a/g)',
'foo.replace(/\\\\./g)',
// Not `CallExpression`
'new foo.replace(/a/g, bar)',
// Not `MemberExpression`
'replace(/a/g, bar)',
// Computed
'foo[replace](/a/g, bar);',
// Not replace
'foo.methodNotReplace(/a/g, bar);',
// `callee.property` is not a `Identifier`
'foo[\'replace\'](/a/g, bar)',
// More or less argument(s)
'foo.replace(/a/g, bar, extra);',
'foo.replace();',
'foo.replace(...argumentsArray, ...argumentsArray2)',
],
invalid: [
{
code: 'foo.replace(/a/g, bar)',
output: 'foo.replaceAll(\'a\', bar)',
errors: [error],
},
// Comments
{
code: `
foo/* comment 1 */
.replace/* comment 2 */(
/* comment 3 */
/a/g // comment 4
,
bar
)
`,
output: `
foo/* comment 1 */
.replaceAll/* comment 2 */(
/* comment 3 */
'a' // comment 4
,
bar
)
`,
errors: [error],
},
// Quotes
{
code: 'foo.replace(/"\'/g, \'\\\'\')',
output: 'foo.replaceAll(\'"\\\'\', \'\\\'\')',
errors: [error],
},
// Escaped symbols
{
code: 'foo.replace(/\\./g, bar)',
output: 'foo.replaceAll(\'.\', bar)',
errors: [error],
},
{
code: 'foo.replace(/\\\\\\./g, bar)',
output: 'foo.replaceAll(\'\\\\.\', bar)',
errors: [error],
},
{
code: 'foo.replace(/\\|/g, bar)',
output: 'foo.replaceAll(\'|\', bar)',
errors: [error],
},
],
});
test.snapshot({
valid: [],
invalid: [
'foo.replace(/a/gu, bar)',
'foo.replace(/a/ug, bar)',
],
});