/
new-for-builtins.js
81 lines (70 loc) · 1.91 KB
/
new-for-builtins.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
'use strict';
const builtins = require('./utils/builtins.js');
const isShadowed = require('./utils/is-shadowed.js');
const {callExpressionSelector, newExpressionSelector} = require('./selectors/index.js');
const {
switchCallExpressionToNewExpression,
switchNewExpressionToCallExpression,
} = require('./fix/index.js');
const messages = {
enforce: 'Use `new {{name}}()` instead of `{{name}}()`.',
disallow: 'Use `{{name}}()` instead of `new {{name}}()`.',
};
/** @param {import('eslint').Rule.RuleContext} context */
const create = context => {
const sourceCode = context.getSourceCode();
return {
[callExpressionSelector(builtins.enforceNew)]: node => {
const {callee, parent} = node;
if (isShadowed(context.getScope(), callee)) {
return;
}
const {name} = callee;
if (
name === 'Object'
&& parent
&& parent.type === 'BinaryExpression'
&& (parent.operator === '===' || parent.operator === '!==')
&& (parent.left === node || parent.right === node)
) {
return;
}
return {
node,
messageId: 'enforce',
data: {name},
fix: fixer => switchCallExpressionToNewExpression(node, sourceCode, fixer),
};
},
[newExpressionSelector(builtins.disallowNew)]: node => {
const {callee} = node;
if (isShadowed(context.getScope(), callee)) {
return;
}
const {name} = callee;
const problem = {
node,
messageId: 'disallow',
data: {name},
};
if (name !== 'String' && name !== 'Boolean' && name !== 'Number') {
problem.fix = function * (fixer) {
yield * switchNewExpressionToCallExpression(node, sourceCode, fixer);
};
}
return problem;
},
};
};
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
create,
meta: {
type: 'suggestion',
docs: {
description: 'Enforce the use of `new` for all builtins, except `String`, `Number`, `Boolean`, `Symbol` and `BigInt`.',
},
fixable: 'code',
messages,
},
};