-
-
Notifications
You must be signed in to change notification settings - Fork 353
/
new-for-builtins.js
323 lines (320 loc) · 7.64 KB
/
new-for-builtins.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
import {test} from './utils/test';
import {enforceNew, disallowNew} from '../rules/utils/builtins';
const enforceNewError = builtin => ({
message: `Use \`new ${builtin}()\` instead of \`${builtin}()\`.`
});
const disallowNewError = builtin => ({
message: `Use \`${builtin}()\` instead of \`new ${builtin}()\`.`
});
test({
testerOptions: {
// Make sure globals don't effect shadowed check result
globals: {
Map: 'writable',
Set: 'readonly',
WeakMap: 'off',
BigInt: 'writable',
Boolean: 'readonly',
Number: 'off'
}
},
valid: [
'const foo = new Object()',
'const foo = new Array()',
'const foo = new ArrayBuffer()',
'const foo = new BigInt64Array()',
'const foo = new BigUint64Array()',
'const foo = new DataView()',
'const foo = new Date()',
'const foo = new Error()',
'const foo = new Float32Array()',
'const foo = new Float64Array()',
'const foo = new Function()',
'const foo = new Int8Array()',
'const foo = new Int16Array()',
'const foo = new Int32Array()',
'const foo = new Map()',
'const foo = new Map([[\'foo\', \'bar\'], [\'unicorn\', \'rainbow\']])',
'const foo = new WeakMap()',
'const foo = new Set()',
'const foo = new WeakSet()',
'const foo = new Promise()',
'const foo = new RegExp()',
'const foo = new UInt8Array()',
'const foo = new UInt16Array()',
'const foo = new UInt32Array()',
'const foo = new Uint8ClampedArray()',
'const foo = BigInt()',
'const foo = Boolean()',
'const foo = Number()',
'const foo = String()',
'const foo = Symbol()',
// Shadowed
...enforceNew.map(object => `
const ${object} = function() {};
const foo = ${object}();
`),
...disallowNew.map(object => `
const ${object} = function() {};
const foo = new ${object}();
`),
...enforceNew.map(object => `
function insideFunction() {
const ${object} = function() {};
const foo = ${object}();
}
`),
...disallowNew.map(object => `
function insideFunction() {
const ${object} = function() {};
const foo = new ${object}();
}
`),
...enforceNew.map(object => `
function outer() {
const ${object} = function() {};
function inner() {
const foo = ${object}();
}
}
`),
...disallowNew.map(object => `
function insideFunction() {
const ${object} = function() {};
function inner() {
const foo = new ${object}();
}
}
`),
// #122
`
import { Map } from 'immutable';
const m = Map();
`,
`
const {Map} = require('immutable');
const foo = Map();
`,
`
const {String} = require('guitar');
const lowE = new String();
`,
`
import {String} from 'guitar';
const lowE = new String();
`,
// Not builtin
'new Foo();Bar();',
'Foo();new Bar();',
// Ignored
'const isObject = v => Object(v) === v;',
'(x) !== Object(x)'
],
invalid: [
{
code: 'const foo = Object()',
errors: [enforceNewError('Object')],
output: 'const foo = new Object()'
},
{
code: 'const foo = Array()',
errors: [enforceNewError('Array')],
output: 'const foo = new Array()'
},
{
code: 'const foo = ArrayBuffer()',
errors: [enforceNewError('ArrayBuffer')],
output: 'const foo = new ArrayBuffer()'
},
{
code: 'const foo = BigInt64Array()',
errors: [enforceNewError('BigInt64Array')],
output: 'const foo = new BigInt64Array()'
},
{
code: 'const foo = BigUint64Array()',
errors: [enforceNewError('BigUint64Array')],
output: 'const foo = new BigUint64Array()'
},
{
code: 'const foo = DataView()',
errors: [enforceNewError('DataView')],
output: 'const foo = new DataView()'
},
{
code: 'const foo = Date()',
errors: [enforceNewError('Date')],
output: 'const foo = new Date()'
},
{
code: 'const foo = Error()',
errors: [enforceNewError('Error')],
output: 'const foo = new Error()'
},
{
code: 'const foo = Error(\'Foo bar\')',
errors: [enforceNewError('Error')],
output: 'const foo = new Error(\'Foo bar\')'
},
{
code: 'const foo = Float32Array()',
errors: [enforceNewError('Float32Array')],
output: 'const foo = new Float32Array()'
},
{
code: 'const foo = Float64Array()',
errors: [enforceNewError('Float64Array')],
output: 'const foo = new Float64Array()'
},
{
code: 'const foo = Function()',
errors: [enforceNewError('Function')],
output: 'const foo = new Function()'
},
{
code: 'const foo = Int8Array()',
errors: [enforceNewError('Int8Array')],
output: 'const foo = new Int8Array()'
},
{
code: 'const foo = Int16Array()',
errors: [enforceNewError('Int16Array')],
output: 'const foo = new Int16Array()'
},
{
code: 'const foo = Int32Array()',
errors: [enforceNewError('Int32Array')],
output: 'const foo = new Int32Array()'
},
{
code: 'const foo = Map()',
errors: [enforceNewError('Map')],
output: 'const foo = new Map()'
},
{
code: 'const foo = Map([[\'foo\', \'bar\'], [\'unicorn\', \'rainbow\']])',
errors: [enforceNewError('Map')],
output: 'const foo = new Map([[\'foo\', \'bar\'], [\'unicorn\', \'rainbow\']])'
},
{
code: 'const foo = WeakMap()',
errors: [enforceNewError('WeakMap')],
output: 'const foo = new WeakMap()'
},
{
code: 'const foo = Set()',
errors: [enforceNewError('Set')],
output: 'const foo = new Set()'
},
{
code: 'const foo = WeakSet()',
errors: [enforceNewError('WeakSet')],
output: 'const foo = new WeakSet()'
},
{
code: 'const foo = Promise()',
errors: [enforceNewError('Promise')],
output: 'const foo = new Promise()'
},
{
code: 'const foo = RegExp()',
errors: [enforceNewError('RegExp')],
output: 'const foo = new RegExp()'
},
{
code: 'const foo = Uint8Array()',
errors: [enforceNewError('Uint8Array')],
output: 'const foo = new Uint8Array()'
},
{
code: 'const foo = Uint16Array()',
errors: [enforceNewError('Uint16Array')],
output: 'const foo = new Uint16Array()'
},
{
code: 'const foo = Uint32Array()',
errors: [enforceNewError('Uint32Array')],
output: 'const foo = new Uint32Array()'
},
{
code: 'const foo = Uint8ClampedArray()',
errors: [enforceNewError('Uint8ClampedArray')],
output: 'const foo = new Uint8ClampedArray()'
},
{
code: 'const foo = new BigInt(123)',
errors: [disallowNewError('BigInt')],
output: 'const foo = BigInt(123)'
},
{
code: 'const foo = new Boolean()',
errors: [disallowNewError('Boolean')],
output: 'const foo = new Boolean()'
},
{
code: 'const foo = new Number()',
errors: [disallowNewError('Number')],
output: 'const foo = new Number()'
},
{
code: 'const foo = new Number(\'123\')',
errors: [disallowNewError('Number')],
output: 'const foo = new Number(\'123\')'
},
{
code: 'const foo = new String()',
errors: [disallowNewError('String')],
output: 'const foo = new String()'
},
{
code: 'const foo = new Symbol()',
errors: [disallowNewError('Symbol')],
output: 'const foo = Symbol()'
},
{
code: `
function varCheck() {
{
var WeakMap = function() {};
}
// This should not reported
return WeakMap()
}
function constCheck() {
{
const Array = function() {};
}
return Array()
}
function letCheck() {
{
let Map = function() {};
}
return Map()
}
`,
errors: [enforceNewError('Array'), enforceNewError('Map')],
output: `
function varCheck() {
{
var WeakMap = function() {};
}
// This should not reported
return WeakMap()
}
function constCheck() {
{
const Array = function() {};
}
return new Array()
}
function letCheck() {
{
let Map = function() {};
}
return new Map()
}
`
}
]
});