Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error serialization #27

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Fix error serialization #27

merged 2 commits into from
Mar 7, 2022

Conversation

erdkse
Copy link
Contributor

@erdkse erdkse commented Mar 4, 2022 •
edited by sindresorhus

  • Change error serialize logic
  • Drop usage of v8's serialize method
  • Start using 'serialize-error' library to serialize errors

Fixes #26

@erdkse
Copy link
Contributor Author

erdkse commented Mar 4, 2022

#26

@Nantris
Copy link
Contributor

Nantris commented Mar 4, 2022

Looks good to me. I didn't know about serialize-error!

@sindresorhus

@sindresorhus sindresorhus changed the title chore: change error serialize logic Fix error serialization Mar 7, 2022
@sindresorhus sindresorhus merged commit a06c404 into sindresorhus:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialized error return Buffer and it is unreadable.
3 participants
@erdkse @Nantris @sindresorhus