Add built-in support for spellchecking #94

nautatva · 2020-02-05T20:45:19Z

Built in support for spell check suggestions. This fixes #11.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#11: Built in support for spell check suggestions

IssueHunt has been backed by the following sponsors. Become a sponsor

nautatva · 2020-02-05T20:46:23Z

This will also solve sindresorhus/caprine#14 which was due and waiting for this PR.

fixture.js

fixture-menu.js

index.d.ts

index.js

package.json

readme.md

sindresorhus · 2020-02-12T20:54:44Z

Make sure it looks exactly like: #11 (comment) I think you've missed some things.

sindresorhus · 2020-02-12T20:55:08Z

This issue has a high bounty, so it's expected that you put a lot of effort into this PR ;)

bigshahan · 2020-02-14T00:29:14Z

Seems like the nodeIntegration: true is needed for the searchWithGoogle option being added. Would it be possible to implement a callback alternative for the menu option, and to avoid the require call? I think it is very important to have a workaround for the nodeIntegration requirement, as there is no way we would ever turn that on in our usage, for security reasons.

nautatva · 2020-02-14T00:38:41Z

Implemented these things in this commit as from the figure in #11 (comment).

The bottom-most options seem more of a system-wide setting change rather than a app-context. Not sure if we can implement this on a non-system app. Even MS-word doesn't have these options.
I was stuck at implementing the ignore spelling part. Can you help me with that please @sindresorhus

nautatva · 2020-02-14T00:48:48Z

I re-checked the searchWithGoogle option and it works even without nodeIntegration: true. Can you recheck if something else isn't being missed out.

bigshahan · 2020-02-14T02:11:17Z

I re-checked the searchWithGoogle option and it works even without nodeIntegration: true. Can you recheck if something else isn't being missed out.

This makes sense, since the context menu is setup in the main process.

sindresorhus · 2020-02-22T09:27:43Z

The bottom-most options seem more of a system-wide setting change rather than a app-context.

Yup. Those are not relevant here. And not possible to implement.

sindresorhus · 2020-02-22T09:28:19Z

I was stuck at implementing the ignore spelling part. Can you help me with that please @sindresorhus

What are you stuck with specifically? What have you tried?

index.d.ts

index.js

sindresorhus · 2020-02-22T09:31:08Z

Don't forget to document all the menu items and options, in both the readme and the TypeScript file. I see some missing things and inconsistencies. The readme and TypeScript file should be in sync.

nautatva · 2020-02-25T14:55:06Z

Had opened a electron issue for the same: electron/electron#22362. I think ignore should be out of question here.

nautatva · 2020-03-04T12:42:45Z

Any updates for changes? @sindresorhus

sindresorhus · 2020-03-09T04:59:05Z

https://github.com/sindresorhus/electron-context-menu/pull/94/files#r378506080 is not fixed.

sindresorhus · 2020-03-09T04:59:16Z

#94 (comment) is not fixed.

sindresorhus · 2020-03-09T05:00:05Z

#94 (comment) is not fixed.

index.js

readme.md

sindresorhus · 2020-03-09T05:00:58Z

Please spend some more time improving the docs and perfecting this PR :)

nautatva · 2020-03-10T19:52:28Z

index.js

nautatva · 2020-03-11T07:45:34Z

Is this okay? Haven't work with this before.

sindresorhus · 2020-03-11T10:51:31Z

index.js

-					const url = new URL('https://www.google.com/search?q=' + props.selectionText).href;
+					const queryParams = {q: props.selectionText};
+					const queryString = new URLSearchParams(queryParams).toString();
+					const url = new URL('https://www.google.com/search?' + queryString).href;


This is not what I asked for. I asked you to use URL#searchParams. const url = new URL(…); url.searchParams.set(…);.

And use url.toString().

Did this in the following commit, but am curious, why can't we use const url = new URL('https://www.google.com/search?' + new URLSearchParams(queryParams).toString()).href;

Is it just because of readability or it due to some other reason as well?

You technically could, but what if you forget to put the ? at the end. I prefer using dedicated APIs for formatting whenever possible to prevent mistakes.

nautatva · 2020-03-20T09:11:50Z

Does this work?

index.d.ts

index.js

sindresorhus · 2020-04-14T07:07:38Z

Yup, looks good now 👍

sindresorhus · 2020-04-14T07:08:26Z

@nautatva Can you do a PR to Caprine now to get the bounty there too?

nautatva · 2020-04-14T18:22:13Z

Done!

Feature:Builtin support for spellcheck suggestions

a0ca442

linting errors

b6d9854

nautatva mentioned this pull request Feb 5, 2020

Various tweaks sindresorhus/caprine#1267

Merged

sindresorhus requested changes Feb 12, 2020

View reviewed changes

nautatva added 2 commits February 14, 2020 05:49

SearchWithGoogle,AutoCorrection,learnSpell support

4ffb76a

extra space removed

57c9515

better nomenclature

4efc985

nautatva requested a review from sindresorhus February 14, 2020 07:57

sindresorhus reviewed Feb 22, 2020

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

sindresorhus reviewed Feb 22, 2020

View reviewed changes

index.js Outdated Show resolved Hide resolved

Refactored code

1e6fe1e

sindresorhus requested changes Mar 9, 2020

View reviewed changes

index.js Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

readme.md Outdated Show resolved Hide resolved

Docs updated to be in sync

f4ebfdd

sindresorhus reviewed Mar 11, 2020

View reviewed changes

index.js Outdated Show resolved Hide resolved

Encoding the URLqueryparams

085c304

sindresorhus reviewed Mar 11, 2020

View reviewed changes

sindresorhus and others added 2 commits March 11, 2020 18:53

Update package.json

8e77f66

encoding the search parameter

fc8f059

myspivey mentioned this pull request Mar 26, 2020

Implement spell checking sindresorhus/caprine#14

Closed

nautatva requested a review from sindresorhus March 27, 2020 03:13

HaNdTriX approved these changes Mar 30, 2020

View reviewed changes

sindresorhus added 4 commits April 6, 2020 22:44

Update readme.md

66afb4d

Update index.d.ts

36899d7

Update index.d.ts

6b867d6

Update readme.md

4160cda

sindresorhus requested changes Apr 6, 2020

View reviewed changes

sindresorhus reviewed Apr 6, 2020

View reviewed changes

index.js Outdated Show resolved Hide resolved

nautatva and others added 2 commits April 7, 2020 19:10

Arranged in same order as they appear in menu.

f27ffa7

Update index.d.ts

4a4ebb2

sindresorhus changed the title ~~Feature:Builtin support for spellcheck suggestions~~ Add built-in support for spellchecking Apr 14, 2020

sindresorhus merged commit 71c5d2e into sindresorhus:master Apr 14, 2020

globau mentioned this pull request Apr 23, 2020

Better integrate Electron>=8.1.1's spell checking nativefier/nativefier#283

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add built-in support for spellchecking #94

Add built-in support for spellchecking #94

nautatva commented Feb 5, 2020 •

edited by sindresorhus

nautatva commented Feb 5, 2020

sindresorhus commented Feb 12, 2020

sindresorhus commented Feb 12, 2020

bigshahan commented Feb 14, 2020

nautatva commented Feb 14, 2020

nautatva commented Feb 14, 2020

bigshahan commented Feb 14, 2020

sindresorhus commented Feb 22, 2020

sindresorhus commented Feb 22, 2020

sindresorhus commented Feb 22, 2020

nautatva commented Feb 25, 2020

nautatva commented Mar 4, 2020 •

edited

sindresorhus commented Mar 9, 2020

sindresorhus commented Mar 9, 2020

sindresorhus commented Mar 9, 2020

sindresorhus commented Mar 9, 2020

nautatva commented Mar 10, 2020

nautatva commented Mar 11, 2020

sindresorhus Mar 11, 2020

sindresorhus Mar 11, 2020

nautatva Mar 11, 2020

sindresorhus Apr 14, 2020

nautatva commented Mar 20, 2020

sindresorhus commented Apr 14, 2020

sindresorhus commented Apr 14, 2020

nautatva commented Apr 14, 2020

Add built-in support for spellchecking #94

Add built-in support for spellchecking #94

Conversation

nautatva commented Feb 5, 2020 • edited by sindresorhus

Referenced issues

nautatva commented Feb 5, 2020

sindresorhus commented Feb 12, 2020

sindresorhus commented Feb 12, 2020

bigshahan commented Feb 14, 2020

nautatva commented Feb 14, 2020

nautatva commented Feb 14, 2020

bigshahan commented Feb 14, 2020

sindresorhus commented Feb 22, 2020

sindresorhus commented Feb 22, 2020

sindresorhus commented Feb 22, 2020

nautatva commented Feb 25, 2020

nautatva commented Mar 4, 2020 • edited

sindresorhus commented Mar 9, 2020

sindresorhus commented Mar 9, 2020

sindresorhus commented Mar 9, 2020

sindresorhus commented Mar 9, 2020

nautatva commented Mar 10, 2020

Docs

Other changes

nautatva commented Mar 11, 2020

sindresorhus Mar 11, 2020

Choose a reason for hiding this comment

sindresorhus Mar 11, 2020

Choose a reason for hiding this comment

nautatva Mar 11, 2020

Choose a reason for hiding this comment

sindresorhus Apr 14, 2020

Choose a reason for hiding this comment

nautatva commented Mar 20, 2020

sindresorhus commented Apr 14, 2020

sindresorhus commented Apr 14, 2020

nautatva commented Apr 14, 2020

nautatva commented Feb 5, 2020 •

edited by sindresorhus

nautatva commented Mar 4, 2020 •

edited