From 93f2c7b32efb376f2273cde98ff46da6d146364e Mon Sep 17 00:00:00 2001 From: Richie Bendall Date: Wed, 8 Sep 2021 15:16:45 +1200 Subject: [PATCH 1/6] Return default value if invalid path provided Signed-off-by: Richie Bendall --- index.js | 2 +- test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/index.js b/index.js index e1f316f..3fe9b42 100644 --- a/index.js +++ b/index.js @@ -39,7 +39,7 @@ module.exports = { const pathArray = getPathSegments(path); if (pathArray.length === 0) { - return; + return value; } for (let i = 0; i < pathArray.length; i++) { diff --git a/test.js b/test.js index 0354205..60ffa73 100644 --- a/test.js +++ b/test.js @@ -211,5 +211,5 @@ test('prevent setting/getting `__proto__`', t => { dotProp.set({}, '__proto__.unicorn', '🦄'); t.not({}.unicorn, '🦄'); // eslint-disable-line no-use-extend-native/no-use-extend-native - t.is(dotProp.get({}, '__proto__'), undefined); + t.false(dotProp.get({}, '__proto__', false)); }); From 5edeec32e6db9c8a38443a0b16c88ae4899fbc05 Mon Sep 17 00:00:00 2001 From: Richie Bendall Date: Wed, 8 Sep 2021 15:24:29 +1200 Subject: [PATCH 2/6] Update test.js --- test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test.js b/test.js index 60ffa73..79629d2 100644 --- a/test.js +++ b/test.js @@ -211,5 +211,6 @@ test('prevent setting/getting `__proto__`', t => { dotProp.set({}, '__proto__.unicorn', '🦄'); t.not({}.unicorn, '🦄'); // eslint-disable-line no-use-extend-native/no-use-extend-native - t.false(dotProp.get({}, '__proto__', false)); + t.is(dotProp.get({}, '__proto__'), undefined); + t.is(dotProp.get({}, '__proto__', '🦄'), '🦄'); }); From ec0f7c9adbe4007e98d62abe42be0be208431284 Mon Sep 17 00:00:00 2001 From: Richie Bendall Date: Wed, 8 Sep 2021 15:40:41 +1200 Subject: [PATCH 3/6] Update test.js --- test.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test.js b/test.js index 79629d2..91906e7 100644 --- a/test.js +++ b/test.js @@ -212,5 +212,8 @@ test('prevent setting/getting `__proto__`', t => { t.not({}.unicorn, '🦄'); // eslint-disable-line no-use-extend-native/no-use-extend-native t.is(dotProp.get({}, '__proto__'), undefined); - t.is(dotProp.get({}, '__proto__', '🦄'), '🦄'); }); + +test('return default value if path is invalid', t => { + t.is(dotProp.get({}, '__proto__', '🦄'), '🦄'); +}) From 66a64302c6cab48607c100cc36c6ae71cadb7046 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Wed, 8 Sep 2021 10:48:40 +0700 Subject: [PATCH 4/6] Update test.js --- test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test.js b/test.js index 91906e7..6c337d4 100644 --- a/test.js +++ b/test.js @@ -215,5 +215,5 @@ test('prevent setting/getting `__proto__`', t => { }); test('return default value if path is invalid', t => { - t.is(dotProp.get({}, '__proto__', '🦄'), '🦄'); + t.is(dotProp.get({}, 'nonexistent', '🦄'), '🦄'); }) From 52cf8f03340ba8df5f1016422e745c342da9fcf4 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Wed, 8 Sep 2021 10:59:09 +0700 Subject: [PATCH 5/6] Update test.js --- test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test.js b/test.js index 6c337d4..afa16a9 100644 --- a/test.js +++ b/test.js @@ -216,4 +216,4 @@ test('prevent setting/getting `__proto__`', t => { test('return default value if path is invalid', t => { t.is(dotProp.get({}, 'nonexistent', '🦄'), '🦄'); -}) +}); From 5b84e6e48143cafa71ef02e527e7413c7fbd82b9 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Wed, 8 Sep 2021 12:00:03 +0700 Subject: [PATCH 6/6] Update test.js --- test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test.js b/test.js index afa16a9..a43c89e 100644 --- a/test.js +++ b/test.js @@ -215,5 +215,5 @@ test('prevent setting/getting `__proto__`', t => { }); test('return default value if path is invalid', t => { - t.is(dotProp.get({}, 'nonexistent', '🦄'), '🦄'); + t.is(dotProp.get({}, 'constructor', '🦄'), '🦄'); });