From ad72c05f66024119ba52807634ff4a3b942c61d3 Mon Sep 17 00:00:00 2001 From: kPherox Date: Wed, 22 May 2019 18:09:56 +0900 Subject: [PATCH 1/5] Fix return type for undefined defaultValue --- index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.d.ts b/index.d.ts index d1ee849..a2046e0 100644 --- a/index.d.ts +++ b/index.d.ts @@ -25,7 +25,7 @@ declare const dotProp: { object: {[key: string]: unknown}, path: string, defaultValue?: T - ): T; + ): T | undefined; /** @param object - Object to set the `path` value. From eeda327c48eb7ea5d1fe70a7275187e64743c742 Mon Sep 17 00:00:00 2001 From: kPherox Date: Wed, 22 May 2019 18:48:27 +0900 Subject: [PATCH 2/5] Fix type has default value --- index.d.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/index.d.ts b/index.d.ts index a2046e0..cce3196 100644 --- a/index.d.ts +++ b/index.d.ts @@ -23,10 +23,15 @@ declare const dotProp: { */ get( object: {[key: string]: unknown}, - path: string, - defaultValue?: T + path: string ): T | undefined; + get( + object: {[key: string]: unknown}, + path: string, + defaultValue: T + ): T; + /** @param object - Object to set the `path` value. @param path - Path of the property in the object, using `.` to separate each nested key. Use `\\.` if you have a `.` in the key. From 85e3f3ed81b5f108ba06d313954431d0e5cd0bbb Mon Sep 17 00:00:00 2001 From: kPherox Date: Wed, 22 May 2019 19:00:04 +0900 Subject: [PATCH 3/5] Add test of set type & undefined defaultValue --- index.test-d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/index.test-d.ts b/index.test-d.ts index b0defbd..b20181e 100644 --- a/index.test-d.ts +++ b/index.test-d.ts @@ -2,6 +2,7 @@ import {expectType} from 'tsd'; import dotProp = require('.'); expectType(dotProp.get({foo: {bar: 'unicorn'}}, 'foo.bar')); +expectType(dotProp.get({foo: {bar: 'unicorn'}}, 'foo.bar')); expectType(dotProp.get({foo: {bar: 'a'}}, 'foo.notDefined.deep')); expectType( dotProp.get({foo: {bar: 'a'}}, 'foo.notDefined.deep', 'default value') From 64886f242461c2fdd81db1f31caed96374de4a2b Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Sun, 9 Jun 2019 14:42:30 +0700 Subject: [PATCH 4/5] Update index.d.ts --- index.d.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/index.d.ts b/index.d.ts index cce3196..8fa21d9 100644 --- a/index.d.ts +++ b/index.d.ts @@ -21,13 +21,12 @@ declare const dotProp: { //=> 'unicorn' ``` */ - get( - object: {[key: string]: unknown}, + get( + object: {[key: string]: any}, path: string ): T | undefined; - get( - object: {[key: string]: unknown}, + object: {[key: string]: any}, path: string, defaultValue: T ): T; From 67d02d91464dd31d2de598b0a1ee82ef9da4b70e Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Wed, 12 Jun 2019 22:55:42 +0700 Subject: [PATCH 5/5] Update index.d.ts --- index.d.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/index.d.ts b/index.d.ts index 8863bd9..a969854 100644 --- a/index.d.ts +++ b/index.d.ts @@ -25,8 +25,7 @@ declare const dotProp: { object: {[key: string]: any}, path: string ): T | undefined; - - get( + get( object: {[key: string]: any}, path: string, defaultValue: T