Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update globby to version 10 #64

Merged
merged 5 commits into from Jul 2, 2019
Merged

Update globby to version 10 #64

merged 5 commits into from Jul 2, 2019

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Dec 3, 2017 •
edited

Maintains the current defaults to avoid breaking B/C

Fixes #63

@odarbelaeze
Copy link

Test pass wit this version, great 😄

@realityking
Copy link
Contributor Author

@sindresorhus Did this one get overlooked?

@sindresorhus
Copy link
Owner

I'm deliberately waiting as we're doing a lot of changes to globby now, so I want to wait until that settles down.

@realityking
Copy link
Contributor Author

That makes sense 👍

@AlexWayfer
Copy link

I'm deliberately waiting as we're doing a lot of changes to globby now, so I want to wait until that settles down.

PR to the branch for this PR maked with globby 8.

I think we can merge it to the original del.

@realityking realityking changed the title Updates globby to version 7.1.1 Updates globby to version 8 Mar 24, 2018
@realityking
Copy link
Contributor Author

realityking commented Jun 17, 2018 •
edited

@sindresorhus I know globby 8 still hasn't quite settled down in terms of performance but would you consider merging (and releasing) an upgrade to version 7? It'd be nice to have the smaller dependency footprint.

@realityking realityking mentioned this pull request Jul 23, 2018
Merged
@realityking realityking changed the title Updates globby to version 8 Updates globby to version 9 Jan 16, 2019
@realityking
Copy link
Contributor Author

Rebased and updates for globby version 9

@realityking
Copy link
Contributor Author

@sindresorhus This PR has been open for well over a year and now covers the 3rd glory version (it was originally opened for globby v7). Is globby still not ready?

@sindresorhus
Copy link
Owner

sindresorhus commented Feb 18, 2019 •
edited

@realityking It's not globby that is not ready, it's the package globby uses, fast-glob. The current version of fast-glob has a large performance and install size regression. They also plan to do several breaking changes regarding options, so I'm holding out for version 3 which will fix all that. https://github.com/mrmlnc/fast-glob/milestone/1

@realityking
Copy link
Contributor Author

Thank you for the explanation! I'll look out for fast-glob 3. 🙂

@chrisblossom chrisblossom mentioned this pull request May 3, 2019
Closed
@sindresorhus
Copy link
Owner

fast-glob v3 is out, and https://github.com/sindresorhus/globby/releases/tag/v10.0.0

Can you update the dependency and fix the merge conflict?

@realityking realityking changed the title Updates globby to version 9 Updates globby to version 10 Jun 30, 2019
@realityking
Copy link
Contributor Author

Updated for globby 10 😎

mrmlnc
mrmlnc reviewed Jun 30, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Updates globby to version 10 Update globby to version 10 Jul 2, 2019
@sindresorhus sindresorhus merged commit 6f96d2d into sindresorhus:master Jul 2, 2019
@realityking realityking deleted the globby branch July 2, 2019 18:42
bors bot added a commit to IMA-WorldHealth/bhima that referenced this pull request Jul 3, 2019
@bors @greenkeeper
Merge #3780
ad5115c 
3780: Update del to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The devDependency [del](https://github.com/sindresorhus/del) was updated from `4.1.1` to `5.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v5.0.0</summary>

<p>This release changes the underlying globbing engine, so you are strongly recommended to use the <code>dryRun</code> option to ensure <code>del</code> still does what you expect before you run it on the real files.</p>
<p>Breaking:</p>
<ul>
<li>Require Node.js 8  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/del/commit/42e67a89f8ba5a25fc73cab0075e8181ee7fc069/hovercard" href="https://urls.greenkeeper.io/sindresorhus/del/commit/42e67a89f8ba5a25fc73cab0075e8181ee7fc069"><tt>42e67a8</tt></a></li>
<li>Update globby from version 6 to version 10 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="278835457" data-permission-text="Issue title is private" data-url="sindresorhus/del#64" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/del/pull/64/hovercard" href="https://urls.greenkeeper.io/sindresorhus/del/pull/64">#64</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/del/commit/6f96d2d4d311a30c5bcc94485f340695e6d24023/hovercard" href="https://urls.greenkeeper.io/sindresorhus/del/commit/6f96d2d4d311a30c5bcc94485f340695e6d24023"><tt>6f96d2d</tt></a><br>
<strong>Important:</strong> If you used any of the <code>globby</code> options, please note that <code>globby</code> switched from using the <code>glob</code> package to <code>fast-glob</code>, so almost all the option names changed. <a href="https://urls.greenkeeper.io/mrmlnc/fast-glob#compatible-with-node-glob">Here's how to migrate the options.</a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/del/compare/v4.1.1...v5.0.0"><tt>v4.1.1...v5.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 6 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/del/commit/c07118089d4e6a4f7df689be888b90b989183d0c"><code>c071180</code></a> <code>5.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/del/commit/a73462cb190415e0cda226df1d68c8c73325da05"><code>a73462c</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/del/commit/6f96d2d4d311a30c5bcc94485f340695e6d24023"><code>6f96d2d</code></a> <code>Update globby to version 10 (#64)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/del/commit/6e23f6ade68dcf5d9fc6be704fdc1deb8f95bf33"><code>6e23f6a</code></a> <code>Tidelift tasks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/del/commit/42e67a89f8ba5a25fc73cab0075e8181ee7fc069"><code>42e67a8</code></a> <code>Require Node.js 8</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/del/commit/535d7755466694c97899b6e5334f60ae1816a4eb"><code>535d775</code></a> <code>Enable the repo sponsor button</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/del/compare/31be0e74e352ac7aae71b330a704756851736880...c07118089d4e6a4f7df689be888b90b989183d0c">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
This was referenced Oct 26, 2019
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmlnc mrmlnc mrmlnc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider bumping globby.
5 participants
@realityking @odarbelaeze @sindresorhus @AlexWayfer @mrmlnc