Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to delete when used with path.join on windows #105

Closed
ramezghaly opened this issue Aug 13, 2019 · 1 comment · Fixed by #100
Closed

fail to delete when used with path.join on windows #105

ramezghaly opened this issue Aug 13, 2019 · 1 comment · Fixed by #100

Comments

@ramezghaly
Copy link

ramezghaly commented Aug 13, 2019

var pathTodelete = path.join('platforms', platform ,'app');
del.sync(pathToDelete]); // will do nothing even if the path does not have patterns

var pathTodelete = path.posix.join('platforms', platform ,'app');
del.sync(pathToDelete]);//works fine

del version 5.0.0
node version 10.16.2

@chrisblossom
Copy link
Contributor

You can no longer pass in paths with backward-slashes. If you need to construct a glob pattern, use path.posix.join() instead of path.join(). You can use slash to transform backward-slash paths to forward-slash paths.

This is expected. Please read https://github.com/sindresorhus/del/releases

See also #100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants