Add benchmarks #101
Merged
Add benchmarks #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jul 13, 2019
benchmark.js
Outdated
| // https://github.com/bestiejs/benchmark.js/issues/136 | ||
| createFixtures(); | ||
|
|
||
| // Async await was giving too many errors. stick with standard promises |
There was a problem hiding this comment.
Huh? What does this mean? Async/await shouldn't work any differently.
There was a problem hiding this comment.
suite.add({
name,
defer: true,
// if you remove setup() the benchmark works as expected
setup() {
},
async fn(deferred) {
// Can't use setup because it isn't called after every defer
// https://github.com/bestiejs/benchmark.js/issues/136
createFixtures();
// Async await was giving too many errors. stick with standard promises
await del(['**/*'], {
cwd: tempDir,
concurrency,
// eslint-disable-next-line promise/prefer-await-to-then
}).then(removedFiles => {
if (removedFiles.length !== fixtures.length) {
const error = new Error(
`"${name}": files removed: ${removedFiles.length}, expected: ${fixtures.length}`,
);
console.error(error);
del.sync(tempDir, { cwd: tempDir, force: true });
// eslint-disable-next-line unicorn/no-process-exit
process.exit(1);
}
deferred.resolve();
});
},
});Gives the error:
del on add-benchmarks [⇡!] is 📦 v5.0.0 via ⬢ v10.16.0 took 6s
➜ node benchmark.js
undefined:9
await del(['**/*'], {
^^^^^
SyntaxError: await is only valid in async function
at Function (<anonymous>)
at createCompiled (/Users/chris/github/del/node_modules/benchmark/benchmark.js:1725:16)
at clock (/Users/chris/github/del/node_modules/benchmark/benchmark.js:1608:58)
at clock (/Users/chris/github/del/node_modules/benchmark/benchmark.js:1818:20)
at new Deferred (/Users/chris/github/del/node_modules/benchmark/benchmark.js:405:7)
at Deferred (/Users/chris/github/del/node_modules/benchmark/benchmark.js:402:16)
at Benchmark.run (/Users/chris/github/del/node_modules/benchmark/benchmark.js:2112:13)
at execute (/Users/chris/github/del/node_modules/benchmark/benchmark.js:860:74)
at Timeout._onTimeout (/Users/chris/github/del/node_modules/lodash/lodash.js:2750:43)
at ontimeout (timers.js:436:11)
There was a problem hiding this comment.
Weird. I already commented on this, but it's gone now... Anyway, I think you're just missing the async keyword for the method. Then it worked for me at least.
|
Results for me on Node.js 12.6.0 and macOS 10.14: How about you? |
|
On my desktop: On my laptop: |
|
Also, if you have any ideas how to remove |
|
Seems like 100 would be a good default. Maybe you could add 200, 300, 400, 500, 1000 to the benchmark too? Just to check. |
Added! From my laptop: |
|
I've resolved the merge conflict and updated to async await. I added the line that demonstrates why I was using normal promises. Let me know if you want me to revert the async await change or remove the |
|
Are you able to run Line 45 in 12c443d Is causing the following error for me: ➜ node benchmark.js
undefined:9
const removedFiles = await del(['**/*'], {
^^^^^
SyntaxError: await is only valid in async function
at Function (<anonymous>)
at createCompiled (/Users/chris/github/del/node_modules/benchmark/benchmark.js:1725:16) |
|
I just forgot to remove the setup method before merging as I had intended to: 728cb7c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not necessarily meant to be merged as is, but meant to try and answer #60.