Fix crashes when wrapping text containing colorized content #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Apr 4, 2021
| @@ -315,6 +315,34 @@ test('align option `left`', t => { | |||
| `); | |||
| }); | |||
|
|
|||
| test('align option (left) does not throw when colorized content > columns', t => { | |||
There was a problem hiding this comment.
this one is not crashing without my fix but I've included it for completeness
Andarist
commented
Apr 4, 2021
Comment on lines
+328
to
+344
| test('align option (center) does not throw when colorized content > columns', t => { | ||
| const longContent = chalk.green('ab').repeat(process.stdout.columns); | ||
| t.notThrows(() => { | ||
| boxen(longContent, { | ||
| align: 'center' | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| test('align option (right) does not throw when colorized content > columns', t => { | ||
| const longContent = chalk.green('ab').repeat(process.stdout.columns); | ||
| t.notThrows(() => { | ||
| boxen(longContent, { | ||
| align: 'right' | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I know that those are not the best tests as they don't quite test the final result but I won't have time to dig into writing better ones.
sindresorhus
changed the title
|
Thanks for fixing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this those repeats:
were called with negative numbers - resulting with:
This was happening because
maxwas computed based oncontentWidthwhich already handled colorized stuff correctly (thanks tostring-widthbeing used inwidest-line) but thelongestLengthonly used the.lengthproperty (so it was computed to a greater number):https://github.com/Andarist/boxen/blob/de1f3c89e9c44823cc0c0a26b8b0fb113d648060/index.js#L127