Support text wrapping #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some various example to https://github.com/sindresorhus/boxen/blob/master/example.js with text wrapping? So we can easily manually verify it works and also show the user that it works great. |
sindresorhus
requested changes
Feb 22, 2020
|
Sorry, I had to rebase to include changes from your branch. Besides I discovered a bug with alignment and fixed it and did all the changes you requested. |
|
Looks good now. Thank you 👍 |
|
Hmm, a test is failing when merged to master: https://travis-ci.com/github/sindresorhus/boxen/jobs/328590367 Could you take a look at it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for wrapping text using
wrap-ansi. It seems to be well tested and takes into consideration both ANSI codes and Unicode characters.This should fix #16.
Closes #36