Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow item's description ending with back-tick #96

Closed
kdeldycke opened this issue Mar 13, 2020 · 3 comments
Closed

Allow item's description ending with back-tick #96

kdeldycke opened this issue Mar 13, 2020 · 3 comments

Comments

@kdeldycke
Copy link
Contributor

I'm maintaining an awesome list on managing engineering teams at: https://github.com/kdeldycke/awesome-management

I'd like one day to graduate this draft and propose it to the canonical awesome repository. To prepare that I need to have the linter validates its content. If the majority of reported errors are fixable, I still stumble upon one issue.

To describe an item, I often quote the original content. Here is an example, in which the following Markdown:

- [Teams are like bread](https://blog.jessitron.com/2019/06/15/teams-are-like-bread/) - `If you have one team where the magic is flourishing, don't kill it. Feed it, grow it, and let it be a source of further strong teams. No rushing.`

is rendered to:

  • Teams are like bread - If you have one team where the magic is flourishing, don't kill it. Feed it, grow it, and let it be a source of further strong teams. No rushing.

awesome-lint reports this as a blocking issue:

✖  XX:XX   List item description must end with proper punctuation   remark-lint:awesome-list-item

For the linter to pass, I need to add a final point, after the back-tick:

- [Teams are like bread](https://blog.jessitron.com/2019/06/15/teams-are-like-bread/) - `If you have one team where the magic is flourishing, don't kill it. Feed it, grow it, and let it be a source of further strong teams. No rushing.`.

Which renders to:

  • Teams are like bread - If you have one team where the magic is flourishing, don't kill it. Feed it, grow it, and let it be a source of further strong teams. No rushing..

I don't know about typographic dogma, but that description ending with 2 points (one quoted, one not) looks unpleasant.

What should be the rule here?

  1. Keep it that way? (i.e. repeating the final point)
  2. Fine-tune awesome-lint to allow for an item's description to end with a back-tick?
@sindresorhus
Copy link
Owner

I don't think backtick is a good way to do inline quotes. It looks quite noisy. I would rather do:

  • Teams are like bread - “If you have one team where the magic is flourishing, don't kill it. Feed it, grow it, and let it be a source of further strong teams. No rushing.”

So we could support .

@kdeldycke
Copy link
Contributor Author

kdeldycke commented Apr 28, 2020

Thanks @sindresorhus for the proposal. Literal “...” quotes are indeed appropriate and I agree with you, these makes inline quotes cleaner and less noisy. I'll adopt them for now on! :)

Now this doesn't really address the core issue which is how to properly terminate descriptions made of quotes. But according the The Punctuation Guide, ending the sentence without a comma is the correct form.

So I guess it's OK for the linter to allow (or better, enforce) the following notation you're proposing above.

I just double-checked today and yes, that form:

- [Teams are like bread](https://blog.jessitron.com/2019/06/15/teams-are-like-bread/) - “If you have one team where the magic is flourishing, don't kill it. Feed it, grow it, and let it be a source of further strong teams. No rushing.”

still produces the following error:

✖  XX:XX  List item description must end with proper punctuation     remark-lint:awesome-list-item

@kdeldycke
Copy link
Contributor Author

For the record, I started to specify the punctuation rules of quotes ar #101. Let's move the conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants