Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test using some canonical lists #142

Merged
merged 10 commits into from Jun 3, 2021
Merged

Add integration test using some canonical lists #142

merged 10 commits into from Jun 3, 2021

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented May 30, 2021

Closes #75

I'm using submodules to create local copies of repos to lint using the awesome-lint CLI. I've used repos from sindresorhus as others listed in #75 end up with hundreds of lint errors.

The test runs the CLI on a submodule and checks that all the errors are expected. A repo with no errors would use t.notThrowsAsync instead.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@sindresorhus
Copy link
Owner

Should I add a Github Actions file to run these tests on new pull requests?

Yes

What should I do when a repo has lint issues already?

Make the test ignore them. Ideally, we should fix the lists.

@NotWoods NotWoods marked this pull request as ready for review June 2, 2021 20:48
test/integration.js Outdated Show resolved Hide resolved
test/integration.js Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 1c46742 into sindresorhus:main Jun 3, 2021
@NotWoods NotWoods deleted the integration branch June 3, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint some canonical lists in awesome-lint CI
2 participants