Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location matching of contributing.md and code-of-conduct.md files #111

Merged
merged 5 commits into from Jul 27, 2020
Merged

Fix location matching of contributing.md and code-of-conduct.md files #111

merged 5 commits into from Jul 27, 2020

Conversation

kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Jul 27, 2020

This PR fix the use of optional folder glob pattern to locate contribution and code of conduct guidelines. Also adds fixtures and unittests.

@kdeldycke
Copy link
Contributor Author

BTW, it seems curly braces pattern (i.e. {.github/,}) are somewhat broken in minimatch: isaacs/minimatch#126

@kdeldycke kdeldycke changed the title Add missing test cases from #102. Fix matching of contributing.md file location. Jul 27, 2020
@kdeldycke kdeldycke changed the title Fix matching of contributing.md file location. Fix location matching of contributing.md and code-of-conduct.md files. Jul 27, 2020
@sindresorhus sindresorhus changed the title Fix location matching of contributing.md and code-of-conduct.md files. Fix location matching of contributing.md and code-of-conduct.md files Jul 27, 2020
@sindresorhus sindresorhus merged commit 4e0aead into sindresorhus:master Jul 27, 2020
@kdeldycke kdeldycke deleted the contributing-test-cases branch July 27, 2020 20:56
@kdeldycke
Copy link
Contributor Author

Thanks @sindresorhus for the quick merge and 0.15.0 release! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants