Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks for proc template #1719

Merged
merged 2 commits into from Aug 31, 2021
Merged

Fix memory leaks for proc template #1719

merged 2 commits into from Aug 31, 2021

Conversation

gassyfeve
Copy link
Contributor

Fix #1714

@gassyfeve gassyfeve mentioned this pull request Aug 31, 2021
Closed
jkowens
jkowens approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@jkowens jkowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

lib/sinatra/base.rb Outdated Show resolved Hide resolved
@jkowens jkowens self-requested a review August 31, 2021 03:19
jkowens
jkowens requested changes Aug 31, 2021
View reviewed changes
Copy link
Member

@jkowens jkowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I see would be to remove that private declaration.

@gassyfeve
Copy link
Contributor Author

Already removed duplicate private

@jkowens jkowens merged commit 2e980f3 into sinatra:master Aug 31, 2021
@jkowens
Copy link
Member

jkowens commented Aug 31, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowens jkowens jkowens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Leak occured when use builder/nokogiri template.
2 participants
@gassyfeve @jkowens