remove detect_rack_handler

[ceclinux]

detect_rack_handler can be remove becaue it has already been implemented in Rack::Handler.pick

[jkowens]

Nice!

[namusyaka]

I think that merging this would require additional work (e.g. document changes about supporting servers) probably, but I haven't specifically identified them.

[jkowens]

@namusyaka it looks like Rack::Handler.pick is functionally identical except for the error message:

    # Select first available Rack handler given an `Array` of server names.
    # Raises `LoadError` if no handler was found.
    #
    #   > pick ['puma', 'webrick']
    #   => Rack::Handler::WEBrick
    def self.pick(server_names)
      server_names = Array(server_names)
      server_names.each do |server_name|
        begin
          return get(server_name.to_s)
        rescue LoadError, NameError
        end
      end

      raise LoadError, "Couldn't find handler for: #{server_names.join(', ')}."
    end

[namusyaka]

Ah I seemed to misunderstand meaning of the server, that fully makes sense.

[namusyaka]

Btw, do we need to lock the version of rack?
I'm not sure when the method was introduced.

[jkowens]

It's been there since Rack 1.5: rack/rack@77506e4

[namusyaka]

cool, i have zero concern now.