Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor refactor #1640

Merged
merged 1 commit into from Oct 2, 2020
Merged

minor refactor #1640

merged 1 commit into from Oct 2, 2020
+4 −6

Conversation

ceclinux
Copy link
Contributor

I refactored little bit while reading the code. Just some minor changes which I think should be self-explanatory.

dentarg
dentarg reviewed Sep 14, 2020
View reviewed changes
lib/sinatra/base.rb Outdated Show resolved Hide resolved
dentarg
dentarg reviewed Sep 14, 2020
View reviewed changes
lib/sinatra/base.rb Outdated Show resolved Hide resolved
@jkowens
Copy link
Member

jkowens commented Sep 23, 2020

Looks good to me, @namusyaka what do you think?

namusyaka
namusyaka requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@namusyaka namusyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ceclinux Thanks for your contribution. Please take a look at my comments.

lib/sinatra/base.rb Outdated Show resolved Hide resolved
lib/sinatra/base.rb Outdated Show resolved Hide resolved
lib/sinatra/base.rb Outdated Show resolved Hide resolved
lib/sinatra/base.rb Show resolved Hide resolved
@ceclinux
Copy link
Contributor Author

Thank you all for the detailed reviews. I reverted all the possible changes except for status in finish method.

namusyaka
namusyaka approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@namusyaka namusyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

lib/sinatra/base.rb Show resolved Hide resolved
@namusyaka namusyaka merged commit 8dc1e4a into sinatra:master Oct 2, 2020
@namusyaka namusyaka added this to the v2.1.1 milestone Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dentarg dentarg dentarg left review comments

@namusyaka namusyaka namusyaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ceclinux @jkowens @dentarg @namusyaka