Drop thin support #1627
Merged
Drop thin support #1627
+153
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
namusyaka
requested changes
Jul 27, 2020
rkmathi
force-pushed
the
rkmathi/drop-thin-support
branch
from
c6d3e34
to
7010c30
Compare
namusyaka
reviewed
Aug 1, 2020
rkmathi
force-pushed
the
rkmathi/drop-thin-support
branch
5 times, most recently
from
a032ccb
to
96d1f0b
Compare
namusyaka
approved these changes
Aug 8, 2020
| @@ -3,7 +3,6 @@ | |||
| # run *one* of these: | |||
| # | |||
| # rackup -s mongrel stream.ru # gem install mongrel | |||
| # thin -R stream.ru start # gem install thin | |||
There was a problem hiding this comment.
Please copy test/integration/rainbows.conf here and add rainbows -c rainbows.conf stream.ru.
test/integration/app.rb
Outdated
| @@ -1,6 +1,10 @@ | |||
| $stderr.puts "loading" | |||
| require 'sinatra' | |||
|
|
|||
| if RUBY_ENGINE == "ruby" | |||
| require_relative './rainbows' | |||
| end | |||
There was a problem hiding this comment.
require_relative 'rainbows' if RUBY_ENGINE == 'ruby'
There was a problem hiding this comment.
rkmathi
force-pushed
the
rkmathi/drop-thin-support
branch
from
96d1f0b
to
7a96472
Compare
|
@namusyaka I fixed. |
rkmathi
added a commit
to rkmathi/sinatra
that referenced
this pull request
Aug 8, 2020
|
Great work @rkmathi! 💯 👏 |
jkowens
added a commit
that referenced
this pull request
Oct 1, 2020
Update README.es.md to follow #1627
namusyaka
added a commit
that referenced
this pull request
Nov 5, 2020
Update README.ja.md to follow #1627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1624
Remove thin to drop support.
Use puma or rainbows instead of thin.