From dde8f0561db34188776f955256cfbd89fe01c8e8 Mon Sep 17 00:00:00 2001 From: Kunpei Sakai Date: Thu, 22 Aug 2019 09:31:07 +0900 Subject: [PATCH] fix a regression, closes #1559 --- lib/sinatra/main.rb | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/lib/sinatra/main.rb b/lib/sinatra/main.rb index 4b6e271b57..d6f9f9a524 100644 --- a/lib/sinatra/main.rb +++ b/lib/sinatra/main.rb @@ -3,7 +3,7 @@ module Sinatra if ARGV.any? require 'optparse' - OptionParser.new { |op| + parser = OptionParser.new { |op| op.on('-p port', 'set the port (default is 4567)') { |val| ParamsConfig[:port] = Integer(val) } op.on('-s server', 'specify rack server/handler (default is thin)') { |val| ParamsConfig[:server] = val } op.on('-q', 'turn on quiet mode (default is off)') { ParamsConfig[:quiet] = true } @@ -15,7 +15,12 @@ module Sinatra op.on('-o addr', "set the host (default is (env == 'development' ? 'localhost' : '0.0.0.0'))") do |val| ParamsConfig[:bind] = val end - }.parse!(ARGV.dup) + } + begin + parser.parse!(ARGV.dup) + rescue => evar + ParamsConfig[:optparse_error] = evar + end end require 'sinatra/base' @@ -29,7 +34,11 @@ class Application < Base set :run, Proc.new { File.expand_path($0) == File.expand_path(app_file) } - ParamsConfig.each { |k, v| set k, v } if run? && ARGV.any? + if run? && ARGV.any? + error = ParamsConfig.delete(:optparse_error) + raise error if error + ParamsConfig.each { |k, v| set k, v } + end end remove_const(:ParamsConfig)