Development 404 page still shows up when using -e production command-line flag

[leafac]

Let server.rb be simply

require "sinatra"

Now run it with

$ ruby server.rb -e production

Sinatra will say that it’s running in production mode:

== Sinatra (v2.0.5) has taken the stage on 4567 for production with backup from Thin

But visit http://localhost:4567 and you’ll see the development 404 page:

I tried this with both WEBrick and Thin.

Of course, the problem goes away when using the APP_ENV environment variable:

$ env APP_ENV=production ruby server.rb

[jkowens]

This is an interesting issue. It happens because this block is called before the command line options are parsed and handled:

sinatra/lib/sinatra/base.rb

Line 1835 in eee711b

configure :development do

Command line options are processed later here:

sinatra/lib/sinatra/main.rb

Line 13 in eee711b

if run? && ARGV.any?

[leafac]

How do you think this problem should be solved?

[jkowens]

Good question, I tried a couple options and realized it isn’t as easy to fix as I hoped. The issue is that classical apps extend Application which extends Base (where the configurations are originally made). So supporting both classic and modular style apps becomes tricky. If anyone has any ideas please chime in 🙂

[leafac]

Hmmm, what if we didn’t offer the command-line flag? It’s awkward that we have two ways of accomplishing the same thing, and it’s difficult to tell which should be preferred (the environment variable, it seems).

[jkowens]

That sounds like a valid option to me. I put together a PR #1547 for another possible solution.