shouldn't the opening example include Sinatra::Application.run! ?

[yoLotus]

Hello,

I tried to run the opening example as written in the first lines of the README but when running ruby myapp.rb it silently exit without listening on port 4567.

I needed to add Sinatra::Application.run! to make it worked:

require 'bundler/inline'
gemfile do
  source 'https://rubygems.org'
  gem 'sinatra'
end

get '/' do
  'Hello world!'
end
Sinatra::Application.run!

Did I miss something?

[namusyaka]

@yoLotus Thanks for your report. That is good point.
At first, we haven't expected to use require 'sinatra' combined with require 'bundler/inline'
Please take a look at:

sinatra/lib/sinatra/main.rb

Line 26 in 69956da

at_exit { Application.run! if $!.nil? && Application.run? }

In your case, Application.run? always returns false because of:

sinatra/lib/sinatra/main.rb

Line 11 in 69956da

set :run, Proc.new { File.expand_path($0) == File.expand_path(app_file) }

app_file indicates actual caller which means bundler/inline.rb so run? always returns false. This is root cause.

In order to avoid the issue quickly, you can do it by setting app_file manually:

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'
  gem 'sinatra', require: 'sinatra'
end

set :app_file, $0

get '/' do
  'Hello world!'
end

However, this is not understandable. We need to take care the case.

[yoLotus]

Hello @namusyaka , thanks for your detailed answer.

I didn't know about the :app_file setting. I tried your example and It worked perfectly.

I usually use bundler/inline script to test gems or quickly write small scripts with ruby, I don't know if it is a common way to do things but If you think it is relevant to add your example in the documentation, I can handle it in a PR. Where should I add it ?

[namusyaka]

@yoLotus Thanks for confirmation.
I'd like to make implementation handle the case rather than documentation. I've just marked this as a bug.

[yoLotus]

Just a side question but I was wondering if it was really necessary to run application.run? in the main.rb here:

at_exit { Application.run! if $!.nil? && Application.run? } 

Only check that $! is nil shouldn't be enough ?

Otherwise when I modify the main.rb like this, it works without to be forced to explicitly set app_file in my script:

module Sinatra
  class Application < Base
    # we assume that the first file that requires 'sinatra' is the
    # app_file. all other path related options are calculated based
    # on this path by default.
    set :app_file, caller_files.first || $0
    set :expanded_caller_files, caller_files.map{ |f| File.expand_path(f) }
    set :run, Proc.new { expanded_caller_files.include?(File.expand_path($0)) }
    # ...
  end
  at_exit { Application.run! if $!.nil? && Application.run? }
end

But I am not sure it's the best way to do...

[namusyaka]

@yoLotus I have created a patch for fixing the issue. Could you take a look?

[yoLotus]

Hello @namusyaka

Just tried your patch by running the example of my first comment of this thread (by removing the Sinatra::Application.run! statement) it works perfectly, and the diff is really minimal.

Don't know if a test should be add, but if you think it is not necessary, everything seems good on my side.

Thanks a lot for the patch!

[namusyaka]

It's worth testing, of course. Thanks for confirming.