Encrypted session cookies #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc-gh
force-pushed
the
encrypted-session-cookies
branch
from
73e152d
to
d61af09
Compare
This class is a replacement for Rack::Session::Cookie and uses AES GCM encryption to protect the session data. This new class thus introduces confidentiality in addition to integrity and authenticity which is already provided by Rack::Session::Cookie via an HMAC. This class will also seamlessly upgrade existing session cookies.
The underlying sessions are now fully encrypted. We can just rely on this feature to protect the header canaries used by SessionHijack.
mjc-gh
force-pushed
the
encrypted-session-cookies
branch
from
d61af09
to
7440f22
Compare
|
Any hope of this eventually getting merged? Should we add a way of opting-in to this feature to start off initially? /cc @zzak |
|
@namusyaka I see this was tagged for 2.1.0. Let me know if there's any more work to do on this PR to get it ready for merging. Thanks! |
|
@mikeycgto Yeah we're going to get this in v2.1.0, thank you for your contribution! |
|
Excellent! Just ping me here if there's anything that needs to be changed or updated. Thanks again! |
|
Hi there, looks like it's been a while -- any word on this getting merged / released? Anything I could do to help? |
|
@mjc-gh there are some conflicts , resolve them may make your work to be merged |
jkowens
force-pushed
the
encrypted-session-cookies
branch
from
fa1efbb
to
3f77b86
Compare
jkowens
force-pushed
the
encrypted-session-cookies
branch
from
3f77b86
to
6d217ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1300.