Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jruby Support #72

Open
dometto opened this issue Aug 14, 2017 · 3 comments
Open

Jruby Support #72

dometto opened this issue Aug 14, 2017 · 3 comments

Comments

@dometto
Copy link

dometto commented Aug 14, 2017

The docs state that jruby is currently not supported, but I can gem install mustermann just fine. Is it ready for use with jruby after all?

I have tried to run the specs on jruby, but this fails because the redcarpet gem required by support is not compatible (it relies on posix-spawn). If I disable the redcarpet dependency in the gemspec, the specs run but result in 23 failures. I take it that is not related to removingredcarpet (since else I should be seeing errors concerning that)?

If not that, can you indicate what needs to happen to fully support jruby? I would be interested in getting that running so when can upgrade gollum to sinatra v2.

@zzak
Copy link
Member

zzak commented Aug 14, 2017

Hi @dometto,

I'm not sure why it's not supported to be honest, but your experience leads me to believe that it isn't.

As far as adding support, I'd need a patch to get it building under CI.

Is this something you'd be interested in working on?

@epergo
Copy link
Member

epergo commented Apr 13, 2021

I have tried to run the specs on jruby, but this fails because the redcarpet gem required by support is not compatible (it relies on posix-spawn). If I disable the redcarpet dependency in the gemspec, the specs run but result in 23 failures. I take it that is not related to removingredcarpet (since else I should be seeing errors concerning that)?

Is it redcarpet even used at all? I fail to find where is being used


Update: Removed at #115

@zzak zzak mentioned this issue May 10, 2021
@dentarg
Copy link
Member

dentarg commented Jul 19, 2022

Looks like there's a bunch of things to investigate for JRuby support: https://github.com/sinatra/mustermann/runs/7393804603?check_suite_focus=true#step:4:1

dentarg added a commit to dentarg/mustermann that referenced this issue Jul 19, 2022
dentarg added a commit to dentarg/mustermann that referenced this issue Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants