Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand hash and array #61

Open
tobidelius opened this issue Apr 5, 2017 · 4 comments
Open

Expand hash and array #61

tobidelius opened this issue Apr 5, 2017 · 4 comments
Labels

Comments

@tobidelius
Copy link

I don't know if this is a bug or just not supported but I tried this eariler:

pattern = Mustermann.new("/books/:id")
pattern.expand(:append, id: 5, include: ["foo"])
Expected: # => "/books/5?include[]=foo"
Actual: # => "/books/5?include=foo"

What do you guys say?

@tobidelius
Copy link
Author

ping

@namusyaka
Copy link
Member

@sandelius I'm sorry for the late reply. I've been so busy recently. However, this feature looks reasonable for me.
If you can dig up into this problem, please write a patch or expected spec.
I will seriously face this problem whenever I can spare time

@zzak
Copy link
Member

zzak commented Aug 26, 2017

To be honest, I'm not sure :( but at this point any behavior change we should treat with caution

@tobidelius
Copy link
Author

tobidelius commented Aug 27, 2017

@zzak That's why I proposed it before 1.0 ^^ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants