Fix regexp for filtering out non-root results being set too early #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
lazily_set_root_regexp
branch
from
98efbb9
to
1e72f52
Compare
PragTob
reviewed
Jun 21, 2020
deivid-rodriguez
force-pushed
the
lazily_set_root_regexp
branch
3 times, most recently
from
7c36827
to
4371596
Compare
|
Doesn't look good to CI though: |
PragTob
reviewed
Jun 21, 2020
If user configures a custom `SimpleCov.root`, results outside of the new root wouldn't be properly filtered out since the regexp for filtering was being set at require time, before the `SimpleCov.root` configuration had been applied. Instead, lazily set this regexp, so that by the time it is used, the new `SimpleCov.root` value is already setup.
deivid-rodriguez
force-pushed
the
lazily_set_root_regexp
branch
from
4371596
to
490da92
Compare
PragTob
approved these changes
Jun 21, 2020
|
Yay! Thank you so much for taking care of this ❤️ |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 14, 2020
Update ruby-simplecov to 0.19.0. 0.19.0 (2020-08-16) ========== ## Breaking Changes * Dropped support for Ruby 2.4, it reached EOL ## Enhancements * observe forked processes (enable with SimpleCov.enable_for_subprocesses). See [#881](simplecov-ruby/simplecov#881), thanks to [@robotdana](https://github.com/robotdana) * SimpleCov distinguishes better that it stopped processing because of a previous error vs. SimpleCov is the originator of said error due to coverage requirements. ## Bugfixes * Changing the `SimpleCov.root` combined with the root filtering didn't work. Now they do! Thanks to [@deivid-rodriguez](https://github.com/deivid-rodriguez) and see [#894](simplecov-ruby/simplecov#894) * in parallel test execution it could happen that the last coverage result was written to disk when it didn't complete yet, changed to only write it once it's the final result * if you run parallel tests only the final process will report violations of the configured test coverage, not all previous processes * changed the parallel_tests merging mechanisms to do the waiting always in the last process, should reduce race conditions ## Noteworthy * The repo has moved to https://github.com/simplecov-ruby/simplecov - everything stays the same, redirects should work but you might wanna update anyhow * The primary development branch is now `main`, not `master` anymore. If you get simplecov directly from github change your reference. For a while `master` will still be occasionally updated but that's no long term solion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user configures a custom
SimpleCov.root, results outside of the new root wouldn't be properly filtered out since the regexp for filtering was being set at require time, before theSimpleCov.rootconfiguration had been applied.Instead, lazily set this regexp, so that by the time it is used, the new
SimpleCov.rootvalue is already setup.Fixes #885.