Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleCov Reporting Differences Between v0.17.1 and v0.18.0 #851

Closed
vanessadean opened this issue Jan 31, 2020 · 1 comment
Closed

SimpleCov Reporting Differences Between v0.17.1 and v0.18.0 #851

vanessadean opened this issue Jan 31, 2020 · 1 comment

Comments

@vanessadean
Copy link

Wanted to surface this issue that has already been reported to Code Climate: codeclimate/codeclimate#937

We ran into same error using simplecov in conjunction with Code Climate after upgrading from 0.17.1 to 0.18.0:

Error: json: cannot unmarshal object into Go struct field input.coverage of type []formatters.NullInt
Usage:
  cc-test-reporter after-build

Here is the version of Code Climate we are running:

RUN curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-0.7.0-netcgo-linux-amd64 -o /usr/local/bin/cc-test-reporter && \
    chmod +x /usr/local/bin/cc-test-reporter

Thanks!

@PragTob
Copy link
Collaborator

PragTob commented Jan 31, 2020

Hi @vanessadean ,

thanks for the report 💚

This is a known issue and you can find more background on it here: codeclimate/test-reporter#413

The short version from my side:

  • code climate integrates with us through an implementation detail whose format was never meant for integration or was documented or anything like that
  • we mentioned this over 2 years ago
  • Before releasing this we gave them notice where communication at one point fizzled out a bit Possible Incompatibility with SimpleCov 0.18+ codeclimate/test-reporter#413 (also pointing out other problems with this)
  • Now it's broken
  • I'll still try to work with them to find a solution that is doable. I'm admittedly not ecstatic about having to change stuff in SimpleCov so that a third party service can work but of course I want people to be able to use SimpleCov and CodeClimate.

So we'll see where/how this goes.

I'll close this issue though, imo the main issue for this is: codeclimate/test-reporter#413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants