Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ujson #48

Closed
simonw opened this issue Nov 8, 2017 · 4 comments
Closed

Switch to ujson #48

simonw opened this issue Nov 8, 2017 · 4 comments
Labels
json-api small wontfix

Comments

@simonw
Copy link
Owner

simonw commented Nov 8, 2017 •
edited

ujson is already a dependency of Sanic, and should be quite a bit faster.
@simonw simonw added the small label Nov 8, 2017
@simonw simonw added this to the v1 stretch goals milestone Nov 8, 2017
@simonw simonw changed the title Switch to ujson (it it's faster) Switch to ujson Nov 9, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 9, 2017

Won't fix: ujson is not compatible with the custom JSON encoder I'm using here: https://github.com/simonw/immutabase/blob/b2dee11fcd989d9e2a7bf4de1e23dbc320c05013/immutabase/app.py#L401-L416

@simonw simonw closed this as completed Nov 9, 2017
@simonw
Copy link
Owner Author

simonw commented Nov 9, 2017

This looks promising: ultrajson/ultrajson#124 (comment)

@simonw simonw reopened this Nov 9, 2017
@simonw simonw modified the milestones: v1 stretch goals, v2: visualization edition Nov 14, 2017
@simonw simonw modified the milestones: v2: visualization edition, Advanced JSON edition Dec 10, 2017
@simonw
Copy link
Owner Author

simonw commented Apr 8, 2018

It would be useful to have a microbenchmark in place to help understand how much of a performance benefit this would actually provide.

@simonw simonw mentioned this issue Jul 12, 2018
Closed
@simonw simonw removed this from the Advanced JSON edition milestone May 13, 2019
@simonw
Copy link
Owner Author

simonw commented Jun 24, 2019

I've seen no evidence that JSON handling is even close to being a performance bottleneck, so wontfix.

@simonw simonw closed this as completed Jun 24, 2019
@simonw simonw added the wontfix label Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
json-api small wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw