Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python version used by official Datasette Docker image #1235

Closed
simonw opened this issue Feb 19, 2021 · 2 comments
Closed

Upgrade Python version used by official Datasette Docker image #1235

simonw opened this issue Feb 19, 2021 · 2 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Feb 19, 2021

Currently uses 3.7.2:

FROM python:3.7.2-slim-stretch as build

There's a security fix for Python which it would be good to ship in this image (even though I'm reasonably confident it doesn't affect Datasette): https://bugs.python.org/issue42938

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

I'll bump to 3.7.10 for the moment - the fix for 3.8 isn't out until March 1st according to https://news.ycombinator.com/item?id=26186434

https://www.python.org/downloads/release/python-3710/

@simonw
Copy link
Owner Author

simonw commented Feb 19, 2021

I bumped the two lines in the Dockerfile to FROM python:3.7.10-slim-stretch as build and ran this to build it:

docker build -f Dockerfile -t datasetteproject/datasette:python-3-7-10 .

Then I ran it with:

docker run -p 8001:8001 -v `pwd`:/mnt datasetteproject/datasette:python-3-7-10 datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db

http://0.0.0.0:8001/-/versions confirmed that it was now running Python 3.7.10

@simonw simonw closed this as completed in a423930 Feb 19, 2021
simonw added a commit that referenced this issue Feb 19, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant