Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache-dependency-path: setup.py #6

Closed
simonw opened this issue Nov 22, 2022 · 6 comments
Closed

cache-dependency-path: setup.py #6

simonw opened this issue Nov 22, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Nov 22, 2022

Can drop the separate cache action entirely.

As seen here: simonw/dclient@d59c680
@simonw simonw added the enhancement New feature or request label Nov 22, 2022
simonw added a commit that referenced this issue Nov 28, 2022
@simonw
Use actions/setup-python cache, refs #6
42b07cf
simonw added a commit that referenced this issue Nov 28, 2022
@simonw
requirements.txt for #6
28ac965
simonw added a commit that referenced this issue Nov 28, 2022
@simonw
Install from the correct path, refs #6
08b7e83
@simonw
Copy link
Owner Author

simonw commented Nov 28, 2022

I tested that this worked correctly by hitting "re-run jobs" on the new runs (e.g. https://github.com/simonw/click-app-template-demo/actions/runs/3569128142) and watching the cache get restored on the second time.

simonw added a commit to simonw/til that referenced this issue Nov 28, 2022
@simonw
actions/setup-python caching for setup.py projects
f23bdca 
Refs simonw/click-app#6
@simonw
Copy link
Owner Author

simonw commented Nov 28, 2022

I'm going to make the same change to my other two cookiecutter templates.

simonw added a commit to simonw/datasette-plugin that referenced this issue Nov 28, 2022
@simonw
Use actions/setup-python cache
66baeb5 
Refs simonw/click-app#6
simonw added a commit to simonw/python-lib that referenced this issue Nov 28, 2022
@simonw
Update to latest workflow pattern
e95589a 
Refs simonw/click-app#6
@simonw
Copy link
Owner Author

simonw commented Nov 28, 2022

python-lib tests failed because I hit a rate limit for checking out the repos: simonw/python-lib@e95589a

Going to wait an hour and try re-running that.

@simonw
Copy link
Owner Author

simonw commented Nov 28, 2022

Wrote a TIL about this: https://til.simonwillison.net/github-actions/cache-setup-py

@simonw
Copy link
Owner Author

simonw commented Nov 28, 2022

OK, tests passed on a retry.

@simonw simonw closed this as completed Nov 28, 2022
@simonw
Copy link
Owner Author

simonw commented Nov 28, 2022

Submitted a PR to the actions/setup-python docs here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw