Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Wrong rendering of emphasis using asterisks #78

Closed
petergardfjall opened this issue Nov 6, 2020 · 4 comments
Closed

bug: Wrong rendering of emphasis using asterisks #78

petergardfjall opened this issue Nov 6, 2020 · 4 comments
Labels
bug

Comments

@petergardfjall
Copy link

petergardfjall commented Nov 6, 2020 •
edited

Context:

  • version (md-to-pdf -v): 3.1.1
  • platform (Unix, macOS, Windows): Linux
  • node version: v12.19.0

Describe the bug:

It seems like the used version of marked (v1.1.1) has a problem in rendering emphasis with asterisks (markedjs/marked#1754).

For example, the following example

$ echo "*A pigeon*: a  type of *bird*" | md-to-pdf --as-html

I would expect to result in HTML such as

<body class="">
<p><em>A pigeon</em>: a  type of <em>bird</em></p>
</body></html>

Actually results in:

<body class="">
<p><em>A pigeon*: a  type of *bird</em></p>
</body></html>

The fix appears to be fixed in marked v1.1.2 (markedjs/marked#1754 (comment)) so please consider upgrading.
@simonhaenisch
Copy link
Owner

Thanks for the issue, yeah i'll upgrade now!

@petergardfjall
Copy link
Author

@simonhaenisch I just submitted a PR: #79

@simonhaenisch
Copy link
Owner

3.1.2 is published on npm now 🤓 cheers 🎉

@petergardfjall
Copy link
Author

Wow, that was fast! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petergardfjall @simonhaenisch