Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addds ruby 3 to CI matrix #352

Merged
merged 6 commits into from Jan 13, 2021
Merged

addds ruby 3 to CI matrix #352

merged 6 commits into from Jan 13, 2021

Conversation

swiknaba
Copy link
Contributor

adds Ruby 3 to CI. Also gitignored a ruby-version file so I can run the tests locally for different versions.

I've run the tests locally for Ruby 3, all ✅

closes #351

@simi
Copy link
Owner

simi commented Jan 13, 2021

Thanks @swiknaba!

I don't really understand the .ruby-version ignoring. Can you please remove it? Also it seems to fail thanks to rbx platform specific gems. Can you remove that from Gemfile as well? We don't test rbx anymore.

@swiknaba
Copy link
Contributor Author

swiknaba commented Jan 13, 2021

I've set Ruby 2.7 and 3 in the ruby version locally, to install and run the tests on different versions and didn't want to check-in a new file.

Aha, the failure is not related to the cache. I can roll that change in CI back if you want.

I'll remove the ruby-version and the rbx. --> done

@simi
Copy link
Owner

simi commented Jan 13, 2021

I think we can revert to using ruby/setup-ruby bundler cache and we're ready to go!

@simi simi merged commit 2e1090f into simi:master Jan 13, 2021
@simi
Copy link
Owner

simi commented Jan 13, 2021

@swiknaba thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add Ruby 3 to the test-matrix
2 participants