Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change secure_image_url default from false to true #346

Merged
merged 3 commits into from Feb 9, 2021

Conversation

swiknaba
Copy link
Contributor

@swiknaba swiknaba commented Oct 20, 2020

Description

Default secure_image_url to true, see #345 for details.

closes #345

Notes

As mentioned here #343 (comment) you can just turn on the secure_image_url in your settings for now. This PR just aims to change the default value, since it is mandatory. Eventually, in the next major version release, we can drop this option entirely, since there is no point in turning SSL off, if the Facebook API does not support it anymore anyway.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@swiknaba
Copy link
Contributor Author

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@simi any decisions on the merge? With the current default, the gem doesn't work out of the box for new installs :s

@github-actions github-actions bot closed this Dec 16, 2020
@simi simi reopened this Dec 16, 2020
@github-actions github-actions bot closed this Dec 22, 2020
@firrae firrae mentioned this pull request Feb 9, 2021
@simi simi reopened this Feb 9, 2021
@simi simi merged commit 853dce6 into simi:master Feb 9, 2021
@simi
Copy link
Owner

simi commented Feb 9, 2021

@swiknaba thanks for this one, it failed out of my radar. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default of secure_image_url to true, because downloading image via http results in 500 error
2 participants