Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of macros SIMDUTF_CAN_ALWAYS_RUN_XYZ #88

Open
WojciechMula opened this issue Dec 30, 2021 · 2 comments
Open

Purpose of macros SIMDUTF_CAN_ALWAYS_RUN_XYZ #88

WojciechMula opened this issue Dec 30, 2021 · 2 comments

Comments

@WojciechMula
Copy link
Collaborator

I see these macros are defined in simdutf/src/simdutf/*.h, but never used in the project. Should they be kept? TBH, don't know what was the initial purpose.

@lemire
Copy link
Member

lemire commented Dec 30, 2021

These macros could be used to remove some bloat and speed up the builds. For example, if SIMDUTF_CAN_ALWAYS_RUN_ARM64 is set, then you do not need to include the fallback kernel when building the library.

We don't use them right now so I think that they can be safely removed.

@WojciechMula
Copy link
Collaborator Author

Sound reasonable. IMHO better would be to utilize them. Although I would go for split into major architectures: x86/ARM/PowerPC and then do some global ifdef-magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants