Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complement find_field() with find_unique_field() #1491

Open
lemire opened this issue Mar 8, 2021 · 1 comment
Open

Complement find_field() with find_unique_field() #1491

lemire opened this issue Mar 8, 2021 · 1 comment
Labels
on demand Related to simdjson::ondemand functionality performance
Projects
On Demand
Milestone
Future Version

Comments

@lemire
Copy link
Member

lemire commented Mar 8, 2021

Currently, the On Demand API has a find_field() function which returns a value matching a given key. In the case where the input JSON has several matching keys, this would return just one of them. We should add a more expensive find_unique_field() function which returns an error if there is more than one matching entry.
@lemire lemire added performance on demand Related to simdjson::ondemand functionality labels Mar 8, 2021
@lemire lemire added this to the 2.0 milestone Mar 8, 2021
@lemire lemire added this to To do in On Demand via automation Mar 8, 2021
@lemire lemire modified the milestones: 2.0, 1.0 Apr 7, 2021
@lemire lemire mentioned this issue Apr 7, 2021
Closed
@lemire lemire added this to In progress in Get simdjson 1.0 out!!! May 24, 2021
@lemire
Copy link
Member Author

lemire commented May 27, 2021

I am pushing this issue to a later release. It is a good idea, but I am no longer convinced that it fits well with our current plans.

@lemire lemire modified the milestones: 1.0, 2.0 May 27, 2021
@lemire lemire removed this from In progress in Get simdjson 1.0 out!!! May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on demand Related to simdjson::ondemand functionality performance
Projects
On Demand
To do
Milestone
Future Version
Development

Successfully merging a pull request may close this issue.

Implements issue 1491 (check for unique keys) simdjson/simdjson
1 participant
@lemire