Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement some of the FCVTZS/FCVTMS/FCVTPS/FCVTNS #1150

Open
mr-c opened this issue Mar 20, 2024 · 1 comment
Open

re-implement some of the FCVTZS/FCVTMS/FCVTPS/FCVTNS #1150

mr-c opened this issue Mar 20, 2024 · 1 comment
Milestone

Comments

@mr-c
Copy link
Collaborator

mr-c commented Mar 20, 2024

Recent Qemu confirms the different behavior that was seen on mac M1 and a Pixel 4a 5g phone versus our previous implementation.

To fix this:

  1. Revert 339ffe4
  2. Adjust the test vectors to match the hardware behavior (or that of a recent Qemu version)
  3. Adjust the software implementations of those intrinsics to match the new test vectors

Note that Arm defines Round towards Zero (RZ) mode as

Means that results are rounded to the nearest representable number that is no greater in magnitude than the unrounded result.

@mr-c
Copy link
Collaborator Author

mr-c commented Mar 20, 2024

@yyctw Is this something you have time to do?

@mr-c mr-c added this to the 0.9.0 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant