Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data mapping not fully reflected in exports #1454

Open
axelboc opened this issue Jul 19, 2023 · 0 comments
Open

Data mapping not fully reflected in exports #1454

axelboc opened this issue Jul 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@axelboc
Copy link
Contributor

axelboc commented Jul 19, 2023

Describe the bug

The export feature (to CSV, TIFF, etc.) does not take into account potential transposition of datasets (or dataset slices). See silx-kit/vscode-h5web#23 (comment)

The getExportURL method that data providers may implement does not receive sufficient information to determine whether users have transposed the dataset/slice they want to export. The current signature of the method is:

public getExportURL?<D extends Dataset<ArrayShape>>(
    format: ExportFormat,
    dataset: D,
    selection: string | undefined,
    value: Value<D>
  ): ExportURL;

To Reproduce

  1. Go to https://h5web.panosc.eu/h5grove
  2. Select dataset /entry_0000/1_integration/results/I
  3. Select Matrix visualization
  4. Export to CSV => 10 rows x 1000 columns
  5. Use dimension mapper sidebar to transpose dataset
  6. Export to CSV again => still 10 rows x 1000 columns (expected 1000 rows x 10 columns)

Can also be reproduced with the Heatmap visualization and the TIFF export, for instance.

Expected behaviour

Exports should reflect potential transposition of the datasets (or dataset slices).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant