Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS5 z-index of dropdown behind TinyMCE #270

Closed
christopherdarling opened this issue Dec 13, 2023 · 5 comments
Closed

SS5 z-index of dropdown behind TinyMCE #270

christopherdarling opened this issue Dec 13, 2023 · 5 comments

Comments

@christopherdarling
Copy link
Contributor

christopherdarling commented Dec 13, 2023

SS5 Screenshot

image

SS4 Screenshot

image

Increasing the z-index of the dropdown seems to fix the issue as .tox .tox-editor-header has a z-index of 1 also.

PR

@michalkleiner
Copy link
Contributor

Thanks for the report @christopherdarling, do you wanna try to create a PR with a fix?

@christopherdarling
Copy link
Contributor Author

@michalkleiner looks like https://github.com/JedWatson/react-select/blob/06e34882638d1526b9f5a1238bb567a3e9460ce5/packages/react-select/src/components/Menu.tsx#L292 needs changing, I have had a look through the docs but can't see a way of updating this.

There is an open ticket (JedWatson/react-select#5329) and a few closed ones on this subject but doesn't seem to be a solution so might be a style we need to override through the tagfield styles. I'll send a PR later/soon.

@christopherdarling
Copy link
Contributor Author

lint wasn't working on my local set up so you may want to re-build this but this seems to work; #271

@christopherdarling
Copy link
Contributor Author

new PR @ #272 @GuySartorelli (with a better description too 😉 )

@GuySartorelli
Copy link
Member

Thanks for reporting and fixing that! The patch will be automatically tagged by GitHub actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants