Casting is not respected when using different case in templates

[GuySartorelli]

Affected Version: 4.x

Description

PHP methods and DataObject properties are case insensitive.
If you get some method or property case insensitively in a template, it will render the correct value but will fall back to the default casting.

Steps to Reproduce

In a page class:

class Page extends SiteTree
{
    public function MyHtmlField()
    {
        return '<strong>strongboi</strong>';
    }
}

In a template:

<h2>Correct casting</h2>
$MyHtmlField
<h2>Incorrect casting</h2>
$myHtmlField

Acceptance Criteria

• The correct casting is applied when you access some property or method with a different case than is defined in PHP code.

PRs

• FIX Normalise casing before casting fields #10470

[michalkleiner]

Could this be caused by the mechanism when it's trying to get an existing method, perhaps in a case-sensitive way, and if it doesn't exist it tries to prepend get there and then the casting is not applied because the method name doesn't match with the get prefix?

[GuySartorelli]

I think the attached PR illustrates the cause pretty well - basically ViewableData::castingHelper() is using isset() to see if the field name is in its casting config - but isset() is case sensitive so of course the following will return false even though the field we want is in the config:

$config = [
    'MyField' => 'Text',
];
isset('myField', $config);

[michalkleiner]

Of course. I missed the link to the PR which I've just approved.

[kinglozzer]

PR merged