MNT Add GitHub Actions CI #10416
Merged
MNT Add GitHub Actions CI #10416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/4.10/backport-ci
branch
3 times, most recently
from
c31a819
to
e20bbd7
Compare
GuySartorelli
requested changes
Jul 21, 2022
emteknetnz
force-pushed
the
pulls/4.10/backport-ci
branch
from
e20bbd7
to
5eb8d3e
Compare
GuySartorelli
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Only change from the last run is changing how we're removing behat tests. We can see the behat test isn't running, and the last run was fully green so we know this one will be green as well. Merging.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH MERGE
Issue silverstripe/gha-ci#37
Includes backport cherry-pick of ec5b94f to fix https://github.com/silverstripe/silverstripe-framework/runs/7441583580?check_suite_focus=true
3) SilverStripe\ORM\Tests\MySQLPDOConnectorTest::testConnectionCharsetControl with data set #1 ('utf8', 'utf8_general_ci', 'utf8_unicode_520_ci')On
Utf8TestHelper::dbVersionhad to change private?stringproperty to a mixed var for php 7.3 support, though it's a private on a TestOnly class so it's fine to merge-up