Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require guzzlehttp/psr7 ^2 #10253

Closed
10 tasks done
emteknetnz opened this issue Mar 8, 2022 · 5 comments
Closed
10 tasks done

Require guzzlehttp/psr7 ^2 #10253

emteknetnz opened this issue Mar 8, 2022 · 5 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 8, 2022

The upgrade to embed/embed v4 uncovered the need to only allow recent versions of guzzlehttp/guzzle

ACs

  • Update framework composer.json to require guzzlehttp/psr7 ^2
  • Update 4.11 changelog
  • Update ckan-registry to use guzzlehttp/guzzle ^7
  • Update frameworktest to use guzzlehttp/guzzle ^7

References

PRs

@emteknetnz emteknetnz changed the title Constrain <7.3.0 of guzzle Constrain <7.3.0 of guzzlehttp/guzzle Mar 8, 2022
@emteknetnz emteknetnz self-assigned this Mar 8, 2022
@emteknetnz emteknetnz changed the title Constrain <7.3.0 of guzzlehttp/guzzle Conflict <7.3.0 of guzzlehttp/guzzle Mar 8, 2022
@emteknetnz
Copy link
Member Author

guzzlehttp/guzzle is not required by embed/embed v4

guzzlehttp/psr7 ^2 is supported by embed/embed v4, though not a composer required. A few other psr7 implementation are supported by embed/embed b4 https://github.com/oscarotero/Embed/blob/master/src%2FHttp%2FFactoryDiscovery.php#L15

silverstripe/assets requires intervention/image https://github.com/silverstripe/silverstripe-assets/blob/1/composer.json#L26

intervention/image requires guzzlehttp/psr7 ~1.1 || ^2.0 https://github.com/Intervention/image/blob/master/composer.json#L17

guzzlehttp/guzzle ^6, and 7.0.0 < 7.3.0 will require guzzlehttp/psr7 ^1.6.1 https://github.com/guzzle/guzzle/blob/6.5/composer.json#L28

guzzlehttp/guzzle ^7.3.0 requires guzzlehttp/psr7 ^1.8.1 || ^2.1 https://github.com/guzzle/guzzle/blob/master/composer.json#L57

@emteknetnz emteknetnz changed the title Conflict <7.3.0 of guzzlehttp/guzzle Require guzzlehttp/psr7 ^2 Mar 8, 2022
@maxime-rainville
Copy link
Contributor

I think we need to update silverstripe/webauthn-authenticator as well because it relies on guzzlehttp/psr7.

@maxime-rainville
Copy link
Contributor

I merged what I could. But I would like to get this in an installable state so I can make sure ckan and webauth work with the newer version of Guzzle.

@maxime-rainville
Copy link
Contributor

The parts that were blocking the embed upgrade have been resolved.

@maxime-rainville
Copy link
Contributor

All done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants