Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byteorder-dependency #42

Merged
merged 1 commit into from Aug 4, 2019
Merged

Remove byteorder-dependency #42

merged 1 commit into from Aug 4, 2019

Conversation

lukaslueg
Copy link
Contributor

This removes this byteorder-dependency which is not strictly needed since Rust 1.32. Due to a single use of TryInto (which could be avoided) the minimum Rust version is now 1.34.2

As one can see, there is a lot more manual reading/writing involved. I think the change is worth losing a dependency, though.

Fixes #40

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
I left a minor comment.

src/gzip.rs Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Aug 4, 2019

Codecov Report

Merging #42 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   91.34%   91.42%   +0.07%     
==========================================
  Files          14       14              
  Lines        1283     1294      +11     
==========================================
+ Hits         1172     1183      +11     
  Misses        111      111
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (ø) ⬆️
src/deflate/encode.rs 96.62% <100%> (+0.02%) ⬆️
src/non_blocking/zlib.rs 95.06% <100%> (+0.25%) ⬆️
src/non_blocking/deflate/decode.rs 86.39% <100%> (+0.24%) ⬆️
src/bit.rs 94.21% <100%> (+0.09%) ⬆️
src/util.rs 91.17% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d1090...ec74ff4. Read the comment docs.

@lukaslueg
Copy link
Contributor Author

Took liberty for force-push the change, getting rid of TryInto. Notice that there does not seem to be a test that actually verifies modification_time.

Copy link
Owner

@sile sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that there does not seem to be a test that actually verifies modification_time.

Hmm...

Anyway, this PR seems good. Thanks!

@sile sile merged commit 1b80cbd into sile:master Aug 4, 2019
@lukaslueg lukaslueg deleted the byteorder_removed branch August 5, 2019 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove byteorder-dependency
3 participants