Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: handler might be string or array of strings #582

Open
morriq opened this issue Aug 10, 2023 · 2 comments
Open

types: handler might be string or array of strings #582

morriq opened this issue Aug 10, 2023 · 2 comments

Comments

@morriq
Copy link

morriq commented Aug 10, 2023

Hello

handler as string[] is correctly displayed in metrics:

http_request_duration_milliseconds_count{handler="/tiles/:segments(*),/tiles",code="200",method="HEAD"} 3

but TS can't agree to use it:

Screenshot 2023-08-10 at 10 45 17

Screenshot 2023-08-10 at 10 45 47

@SimenB
Copy link
Collaborator

SimenB commented Sep 19, 2023

Happy to take a PR 🙂

@zbjornson
Copy link
Collaborator

I'm not sure if that is works by intent or chance, actually. If you want to make it PR, it would need to add tests in addition to the typescript declaration changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants