Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all the tests that should be required are required for submission. #289

Closed
vaikas opened this issue Aug 12, 2022 · 1 comment · Fixed by sigstore/community#99
Closed
Assignees
Labels
bug Something isn't working

Comments

@vaikas
Copy link
Contributor

vaikas commented Aug 12, 2022

Description
Need to vet and update this with the correct branch protections:
https://github.com/sigstore/community/blob/main/github-sync/github-data/repositories.yaml

Currently only these are 'required':

        statusChecks:
          - license boilerplate check
          - DCO
          - Analyze (go)
          - Shellcheck

But that's not enough, need to add the proper tests. This is especially troublesome with the 'enable automerge' which could cause accidental merges even if some of the tests are failing.

Version
head

@vaikas vaikas added the bug Something isn't working label Aug 12, 2022
@cpanato cpanato self-assigned this Aug 16, 2022
@cpanato
Copy link
Member

cpanato commented Aug 16, 2022

pr to update the checks sigstore/community#99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants