Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rekor-cli backwards incompatibility & run harness tests against HEAD #1030

Merged
merged 7 commits into from Sep 8, 2022

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Sep 6, 2022

also updates rekor-cli to iterate through all supported versions

@priyawadhwa priyawadhwa requested a review from a team as a code owner September 6, 2022 23:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1030 (a8bff99) into main (a6e58f7) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1030      +/-   ##
==========================================
- Coverage   41.34%   41.07%   -0.28%     
==========================================
  Files          70       70              
  Lines        6994     7040      +46     
==========================================
  Hits         2892     2892              
- Misses       3797     3843      +46     
  Partials      305      305              
Impacted Files Coverage Δ
cmd/rekor-cli/app/upload.go 2.65% <0.00%> (-0.38%) ⬇️
pkg/types/entries.go 5.08% <ø> (ø)
pkg/types/intoto/intoto.go 15.87% <0.00%> (-16.39%) ⬇️
pkg/types/tuf/v0.0.1/entry.go 42.04% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa changed the title Run harness tests against 2 previous versions and HEAD Fix rekor-cli backwards incompatibility & run harness tests against HEAD Sep 7, 2022
@priyawadhwa
Copy link
Contributor Author

Couple updates:

  1. Harness tests are currently failing because server @ HEAD returns an EntryID but rekor-cli get v0.10.0/v0.11.0 return a UUID. With Create EntryID for new artifacts and return EntryID to user #623 already merged it's a breaking change and users will need to update to rekor-cli v0.12.0 for rekor-cli get to work.
  2. I couldn't get the iterator to work but I can give it another go tomorrow

Signed-off-by: Bob Callaway <bcallaway@google.com>
@priyawadhwa priyawadhwa force-pushed the harness-head branch 2 times, most recently from 41c9efe to c911f94 Compare September 7, 2022 18:33
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa force-pushed the harness-head branch 5 times, most recently from ea26c5c to 56dd784 Compare September 7, 2022 23:23
…sion

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa merged commit a6d36b8 into sigstore:main Sep 8, 2022
@priyawadhwa priyawadhwa deleted the harness-head branch September 8, 2022 17:20
@github-actions github-actions bot added this to the v1.0.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants