Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Checkpoint origin to be "Hostname - Tree ID" #1013

Merged
merged 1 commit into from Aug 30, 2022

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Aug 29, 2022

This follows the checkpoint specification, making the origin unique per
environment and shard.

Fixes #1010

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Release Note

Changed origin of checkpoint to be hostname - treeID

Documentation

This follows the checkpoint specification, making the origin unique per
environment and shard.

Fixes sigstore#1010

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

Verified locally with hostname set to rekor.localhost:

curl localhost:3000/api/v1/log
{"inactiveShards":null,"rootHash":"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855","signedTreeHead":"rekor.localhost - 7098144610486104480\n0\n47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=\nTimestamp: 1661810402204554901\n\n— rekor.localhost AO790jBEAiAhEyLAFSkv+SuZxFc80qX/h998AcpJmYFA2dIijjhEbwIgQk77kSz/JmT82F9jcb/ubNKYX+EodifQotp+k0ZtHM8=\n","treeID":"7098144610486104480","treeSize":0}

The first line of signedTreeHead is rekor.localhost - 7098144610486104480, the hostname and tree ID.

@dlorenc dlorenc merged commit 7492834 into sigstore:main Aug 30, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoint: Should the Origin be the Tree ID?
3 participants