Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backfill-redis to the release artifacts #1174

Merged
merged 2 commits into from Nov 10, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 4, 2022

Summary

  • Add backfill-redis to the release artifacts
  • add version information for backfill-redis

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato requested a review from a team as a code owner November 4, 2022 09:55
@codecov-commenter
Copy link

Codecov Report

Merging #1174 (2224286) into main (7412e93) will decrease coverage by 15.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1174       +/-   ##
===========================================
- Coverage   64.23%   48.86%   -15.38%     
===========================================
  Files          82       82               
  Lines        7623     7623               
===========================================
- Hits         4897     3725     -1172     
- Misses       2098     3196     +1098     
- Partials      628      702       +74     
Flag Coverage Δ
e2etests 48.86% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/timestamp_note.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/types/cose/cose.go 25.92% <0.00%> (-74.08%) ⬇️
pkg/signer/file.go 0.00% <0.00%> (-70.00%) ⬇️
pkg/pki/ssh/sign.go 0.00% <0.00%> (-65.12%) ⬇️
pkg/sharding/log_index.go 38.88% <0.00%> (-55.56%) ⬇️
pkg/types/intoto/v0.0.1/entry.go 17.64% <0.00%> (-53.85%) ⬇️
pkg/types/cose/v0.0.1/entry.go 0.44% <0.00%> (-53.54%) ⬇️
pkg/util/sha.go 46.66% <0.00%> (-53.34%) ⬇️
pkg/types/helm/v0.0.1/entry.go 0.42% <0.00%> (-47.06%) ⬇️
pkg/sharding/ranges.go 21.84% <0.00%> (-42.86%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, this won't build artifacts for GH because we don't specify that in goreleaser, correct?

Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@cpanato
Copy link
Member Author

cpanato commented Nov 4, 2022

To confirm, this won't build artifacts for GH because we don't specify that in goreleaser, correct?

Yes, it only build the image

@haydentherapper
Copy link
Contributor

@priyawadhwa Can we get this into the release too? And cherry pick in #1163?

@priyawadhwa
Copy link
Contributor

Sure! could you open a PR for the cherry-pick and I can approve it?

priyawadhwa pushed a commit that referenced this pull request Nov 10, 2022
* Add script to backfill Redis from Rekor (#1163)

* Add script to backfill Redis from Rekor

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Address comments

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Fix bugs in script

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Clean up, change flag name

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Add value removal before upload, print all errors

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* Remove intoto 0.0.2 from backfill

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>

* add backfill-redis to the release

Signed-off-by: cpanato <ctadeu@gmail.com>

* add version information for backfill-redis

Signed-off-by: cpanato <ctadeu@gmail.com>

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Co-authored-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato merged commit f11df4b into sigstore:main Nov 10, 2022
@cpanato cpanato deleted the add-backredis-release branch November 10, 2022 10:14
@github-actions github-actions bot added this to the v1.1.0 milestone Nov 10, 2022
@cpanato
Copy link
Member Author

cpanato commented Nov 10, 2022

@priyawadhwa @haydentherapper will cherry pick this

cpanato added a commit to cpanato/rekor that referenced this pull request Nov 10, 2022
* add backfill-redis to the release

Signed-off-by: cpanato <ctadeu@gmail.com>

* add version information for backfill-redis

Signed-off-by: cpanato <ctadeu@gmail.com>

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants