Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new rekor metrics for latency and QPS. #1059

Merged
merged 2 commits into from Sep 20, 2022

Conversation

var-sdk
Copy link

@var-sdk var-sdk commented Sep 20, 2022

The current server metrics have two problems:

  1. They don't capture method so we can't differentiate POST vs GET/write vs read.
  2. They use the path as passed by the caller for the path field. This prevents us from aggregating correctly ("api/v1/log" is a different time series than "api/v1/log/") and can be a scale risk as it lets end users create new time series arbitrarily.

The two new metrics track latency by endpoint/method, and qps by endpoint/method/status code for error budget. The old metrics will be removed once monitoring has been updated to use the new metrics.

Summary

Release Note

Documentation

Simon Kent added 2 commits September 19, 2022 17:25
Signed-off-by: Simon Kent <simek@google.com>
Signed-off-by: Simon Kent <simek@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #1059 (7e900ed) into main (8260a79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files          71       71           
  Lines        7061     7061           
=======================================
  Hits         2897     2897           
  Misses       3858     3858           
  Partials      306      306           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@var-sdk var-sdk marked this pull request as ready for review September 20, 2022 03:53
@var-sdk var-sdk requested a review from a team as a code owner September 20, 2022 03:53
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@bobcallaway bobcallaway merged commit f27af35 into sigstore:main Sep 20, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants