Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sigstore/sigstore from 1.3.1 to 1.4.0 #745

Merged
merged 6 commits into from Aug 21, 2022

Conversation

k4leung4
Copy link
Contributor

Signed-off-by: Kenny Leung kleung@chainguard.dev

Summary

bump sigstore/sigstore from 1.3.1 to 1.4.0

Release Note

NONE

Documentation

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing lgtm, seems like something changed?

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@k4leung4 k4leung4 marked this pull request as draft August 21, 2022 00:31
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@haydentherapper
Copy link
Contributor

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #745 (0ccad6c) into main (ab74398) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   54.18%   54.05%   -0.14%     
==========================================
  Files          36       36              
  Lines        2257     2257              
==========================================
- Hits         1223     1220       -3     
- Misses        942      944       +2     
- Partials       92       93       +1     
Impacted Files Coverage Δ
pkg/ca/fileca/load.go 58.62% <0.00%> (-10.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@k4leung4
Copy link
Contributor Author

To fix the test, update https://github.com/sigstore/fulcio/blob/main/pkg/server/grpc_server_test.go#L959 and https://github.com/sigstore/fulcio/blob/main/pkg/server/grpc_server_test.go#L1366 to be PublicKeyPEMType.

thanks for pointing me in the right direction. fixed.

@k4leung4 k4leung4 marked this pull request as ready for review August 21, 2022 13:21
@haydentherapper haydentherapper merged commit 3cc125b into sigstore:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants