Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch TSA certificates from TUF targets when available #3563

Open
haydentherapper opened this issue Feb 28, 2024 · 1 comment · May be fixed by #3600
Open

Fetch TSA certificates from TUF targets when available #3563

haydentherapper opened this issue Feb 28, 2024 · 1 comment · May be fixed by #3600
Assignees
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

The sigstore/sigstore TUF client has been updated to support the "TSA" usage type. We currently require the TSA cert chain to be provided by flag. We can also support reading the cert chain from either an environment or the TUF targets, to be more in line with how Fulcio certs or Rekor keys can be provided on verification. See RekorPubKeys as an example for how to support this. Ideally we can refactor all places where we read in the TSA cert chain via flag into a single function that reads from either a flag, env var, or TUF.

Note that as described in sigstore/scaffolding#1001, the usage type will be deprecated in the near future, but given the simplicity of adding this feature, it's worthwhile to do now.

@haydentherapper haydentherapper added the enhancement New feature or request label Feb 28, 2024
@ianhundere
Copy link

@haydentherapper i opened a draft PR for this, didn't write a tsalog_test, but wanted to get this 👀 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants